fix(bean): 修复FastBeanCopier对CharSequence属性的复制支持#353
Merged
Conversation
4d699f3 to
44b596b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
FastBeanCopier在复制到CharSequence属性时缺少直接类型转换支持的问题CharSequence属性失败核心变动
hsweb-core:在FastBeanCopier.DefaultConverter中将CharSequence.class纳入与String.class相同的直接转换分支hsweb-core:为FastBeanCopierTest增加testCharSequenceString -> CharSequenceMap(Number) -> CharSequence测试结果
export JAVA_HOME=$(/usr/libexec/java_home -v 17) && ./mvnw -pl hsweb-core -Dtest=FastBeanCopierTest testFastBeanCopier本次变更行):line 100.00% (3/3), branch 100.00% (6/6)风险与说明
FastBeanCopier对CharSequence目标属性的默认转换逻辑String.valueOf(source)行为,不改变String分支已有语义FastBeanCopier,不扩展其他独立类型转换入口