Inline mktmpdir helper methods

Merge resolve_tmpdir and make_tmpdir directly into mktmpdir since
they are only called from that single method.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: hsbt

pathname.rb

@@ -1433,7 +1433,35 @@ def rmtree
   #   end
   #
   def self.mktmpdir
-    path = make_tmpdir(resolve_tmpdir)
+    tmpdir = nil
+    ['TMPDIR', 'TMP', 'TEMP'].each do |name|
+      dir = ENV[name] rescue next
+      next if dir.nil? || dir.empty?
+      dir = File.expand_path(dir)
+      stat = File.stat(dir) rescue next
+      next unless stat.directory?
+      next unless File.writable?(dir)
+      next if stat.world_writable? && !stat.sticky?
+      tmpdir = dir
+      break
+    end
+    unless tmpdir
+      systmpdir = (defined?(Etc.systmpdir) ? Etc.systmpdir : '/tmp')
+      tmpdir = (File.directory?(systmpdir) && File.writable?(systmpdir)) ? systmpdir : '/tmp'
+    end
+
+    t = Time.now.strftime("%Y%m%d")
+    n = nil
+    begin
+      name = "d#{t}-#{$$}-#{Random.urandom(4).unpack1("L").%(36**6).to_s(36)}#{n ? "-#{n}" : ''}"
+      dir = File.join(tmpdir, name)
+      Dir.mkdir(dir, 0700)
+    rescue Errno::EEXIST
+      n = (n || 0) + 1
+      retry
+    end
+
+    path = new(dir)
     if block_given?
       begin
         yield path
@@ -1458,38 +1486,6 @@ def remove_entry(path)
       File.unlink(path)
     end
   end
-
-  def self.resolve_tmpdir
-    ['TMPDIR', 'TMP', 'TEMP'].each do |name|
-      dir = ENV[name] rescue next
-      next if dir.nil? || dir.empty?
-      dir = File.expand_path(dir)
-      stat = File.stat(dir) rescue next
-      next unless stat.directory?
-      next unless File.writable?(dir)
-      next if stat.world_writable? && !stat.sticky?
-      return dir
-    end
-    systmpdir = (defined?(Etc.systmpdir) ? Etc.systmpdir : '/tmp')
-    return systmpdir if File.directory?(systmpdir) && File.writable?(systmpdir)
-    '/tmp'
-  end
-  private_class_method :resolve_tmpdir
-
-  def self.make_tmpdir(tmpdir)
-    t = Time.now.strftime("%Y%m%d")
-    n = nil
-    begin
-      name = "d#{t}-#{$$}-#{Random.urandom(4).unpack1("L").%(36**6).to_s(36)}#{n ? "-#{n}" : ''}"
-      path = File.join(tmpdir, name)
-      Dir.mkdir(path, 0700)
-    rescue Errno::EEXIST
-      n = (n || 0) + 1
-      retry
-    end
-    new(path)
-  end
-  private_class_method :make_tmpdir
 end
 
 class Pathname