Skip to content

Commit b096cfc

Browse files
committed
Remove usage of Field.from_options
1 parent 69be2f5 commit b096cfc

4 files changed

Lines changed: 27 additions & 6 deletions

File tree

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.1
1+
3.1.0

Gemfile.lock

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ GEM
2727
addressable (2.8.0)
2828
public_suffix (>= 2.0.2, < 5.0)
2929
ast (2.4.1)
30-
base64 (0.2.0)
30+
base64 (0.3.0)
3131
benchmark-ips (2.8.2)
3232
bigdecimal (3.1.8)
3333
concurrent-ruby (1.3.4)
@@ -41,14 +41,15 @@ GEM
4141
domain_name (0.5.20190701)
4242
unf (>= 0.0.5, < 1.0.0)
4343
drb (2.2.1)
44-
fiber-storage (1.0.0)
44+
fiber-storage (1.0.1)
4545
gqli (1.0.0)
4646
hashie (~> 3.0)
4747
http (> 0.8, < 3.0)
4848
multi_json (~> 1)
49-
graphql (2.3.19)
49+
graphql (2.5.18)
5050
base64
5151
fiber-storage
52+
logger
5253
groupdate (6.5.1)
5354
activesupport (>= 7)
5455
gruff (0.10.0)

lib/graphql/groups/has_aggregates.rb

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,17 @@ def aggregate(name, *_, **options, &block)
3030
end
3131

3232
def aggregate_field(*args, **kwargs, &block)
33-
field_defn = Schema::AggregateField.from_options(*args, owner: self, **kwargs, &block)
33+
if args.any?
34+
name_arg = args.shift
35+
type_arg = args.shift
36+
desc_arg = args.shift
37+
38+
kwargs[:name] ||= name_arg
39+
kwargs[:type] ||= type_arg if type_arg
40+
kwargs[:description] ||= desc_arg if desc_arg
41+
end
42+
43+
field_defn = Schema::AggregateField.new(owner: self, **kwargs, &block)
3444
field_defn.ensure_loaded if Gem::Version.new(GraphQL::VERSION) >= Gem::Version.new('2.3')
3545
add_field(field_defn)
3646
field_defn

lib/graphql/groups/has_groups.rb

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,17 @@ def by(name, **options, &block)
3737
end
3838

3939
def group_field(*args, **kwargs, &block)
40-
field_defn = field_class.from_options(*args, owner: self, **kwargs, &block)
40+
if args.any?
41+
name_arg = args.shift
42+
type_arg = args.shift
43+
desc_arg = args.shift
44+
45+
kwargs[:name] ||= name_arg
46+
kwargs[:type] ||= type_arg if type_arg
47+
kwargs[:description] ||= desc_arg if desc_arg
48+
end
49+
50+
field_defn = field_class.new(owner: self, **kwargs, &block)
4151
add_field(field_defn)
4252
field_defn
4353
end

0 commit comments

Comments
 (0)