Fix compatibility with GraphQL 2.5.18 (removal of from_options)#25
Merged
Conversation
Owner
|
Thanks for the PR! Haven't updated this gem in a while, which is the cause for current CI failures. Want to give that a try as well? |
iChebbi
commented
Feb 2, 2026
Contributor
Author
|
@hschne checks are green minus the coverage part. |
hschne
reviewed
Feb 4, 2026
Owner
hschne
left a comment
hschne
left a comment
There was a problem hiding this comment.
Thank you for the PR once again. Just some clarifying questions from my side, happy to merge and release this after those are addressed 🙌
Owner
|
I'll clean up the build & dependency stuff and draft a release this weekend. Thanks for your contribution @iChebbi! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL::Schema::Field.from_options method was removed in GraphQL 2.5.18 PR
I have verified changes by running
bundle exec rspec