Refactor JSON processing in aicode-preprocess.yml

Refactor JSON handling in workflow to use a temporary file for improved reliability and avoid shell quoting issues.

Author: htilly

.github/workflows/aicode-preprocess.yml

@@ -59,49 +59,38 @@ jobs:
           JSON_LINE=$(echo "$OUTPUT" | grep "ENHANCED_TASK_JSON:" || true)
           if [ -n "$JSON_LINE" ]; then
             JSON_DATA=$(echo "$JSON_LINE" | sed 's/ENHANCED_TASK_JSON://')
-            # Use multiline format to avoid shell quoting issues with JSON
-            echo "task_json<<EOF" >> $GITHUB_OUTPUT
-            echo "$JSON_DATA" >> $GITHUB_OUTPUT
-            echo "EOF" >> $GITHUB_OUTPUT
-
+            # Write JSON to file to avoid shell quoting issues when reading back
+            echo "$JSON_DATA" > /tmp/task_json.json
+            
             # Extract Confluence URL
             CONFLUENCE_URL=$(echo "$JSON_DATA" | jq -r '.confluenceUrl // "N/A"')
             echo "confluence_url=$CONFLUENCE_URL" >> $GITHUB_OUTPUT
+            echo "has_json=true" >> $GITHUB_OUTPUT
           else
             echo "confluence_url=N/A" >> $GITHUB_OUTPUT
+            echo "has_json=false" >> $GITHUB_OUTPUT
           fi
 
       - name: Trigger main agent workflow
         if: always()
         run: |
-          # Read enhanced task from JSON output to avoid shell quoting issues
-          # Use jq to safely parse the JSON string from GitHub Actions output
-          TASK_JSON_RAW="${{ steps.preprocess.outputs.task_json }}"
-          
-          if [ -n "$TASK_JSON_RAW" ] && [ "$TASK_JSON_RAW" != "null" ] && [ "$TASK_JSON_RAW" != "" ]; then
-            # Try to parse as JSON - if it's already a JSON string, parse it first
-            if echo "$TASK_JSON_RAW" | jq -e . >/dev/null 2>&1; then
-              # It's valid JSON, extract values
-              ENHANCED_TASK=$(echo "$TASK_JSON_RAW" | jq -r '.enhanced // empty')
-              ORIGINAL_TASK=$(echo "$TASK_JSON_RAW" | jq -r '.original // empty')
-              CONFLUENCE_URL=$(echo "$TASK_JSON_RAW" | jq -r '.confluenceUrl // "N/A"')
+          # Read enhanced task from JSON file to avoid shell quoting issues
+          # Check if JSON file exists from previous step
+          if [ -f /tmp/task_json.json ]; then
+            # Read JSON from file and extract values
+            if jq -e . /tmp/task_json.json >/dev/null 2>&1; then
+              # Valid JSON, extract values
+              ENHANCED_TASK=$(jq -r '.enhanced // empty' /tmp/task_json.json)
+              ORIGINAL_TASK=$(jq -r '.original // empty' /tmp/task_json.json)
+              CONFLUENCE_URL=$(jq -r '.confluenceUrl // "N/A"' /tmp/task_json.json)
             else
-              # Might be a JSON string that needs to be parsed (double-encoded)
-              # Try to unescape and parse
-              TASK_JSON_PARSED=$(echo "$TASK_JSON_RAW" | jq -Rr '.')
-              if echo "$TASK_JSON_PARSED" | jq -e . >/dev/null 2>&1; then
-                ENHANCED_TASK=$(echo "$TASK_JSON_PARSED" | jq -r '.enhanced // empty')
-                ORIGINAL_TASK=$(echo "$TASK_JSON_PARSED" | jq -r '.original // empty')
-                CONFLUENCE_URL=$(echo "$TASK_JSON_PARSED" | jq -r '.confluenceUrl // "N/A"')
-              else
-                # Fallback to outputs if JSON parsing fails
-                ENHANCED_TASK="${{ steps.preprocess.outputs.enhanced_task }}"
-                ORIGINAL_TASK="${{ github.event.client_payload.task }}"
-                CONFLUENCE_URL="${{ steps.preprocess.outputs.confluence_url }}"
-              fi
+              # Invalid JSON, fallback to outputs
+              ENHANCED_TASK="${{ steps.preprocess.outputs.enhanced_task }}"
+              ORIGINAL_TASK="${{ github.event.client_payload.task }}"
+              CONFLUENCE_URL="${{ steps.preprocess.outputs.confluence_url }}"
             fi
           else
-            # Fallback to outputs if JSON not available
+            # No JSON file, fallback to outputs
             ENHANCED_TASK="${{ steps.preprocess.outputs.enhanced_task }}"
             ORIGINAL_TASK="${{ github.event.client_payload.task }}"
             CONFLUENCE_URL="${{ steps.preprocess.outputs.confluence_url }}"