Fix all Slack notifications and improve diff truncation detection

- Fix all Slack notification steps to use JSON file approach (avoid shell quoting)
- Extract task/requester from event payload using jq instead of direct substitution
- Prevents 'Admin to SlackONOS: command not found' errors
- Improve diff truncation detection to catch small incomplete diffs
- Better error messages for truncated diffs with troubleshooting suggestions
- Detects mid-file-path truncation (+++ b/p) even for small diffs

Author: htilly

.github/agent/agent.mjs

@@ -1050,11 +1050,16 @@ if (validationResult.errors.length > 0 || diff.match(/\+\+\+ b\/[^\n]*$/m)) {
   console.warn(`[AGENT] Diff length: ${diffLength} characters`);
   console.warn(`[AGENT] Last 5 lines:\n${lastLines}`);
 
-  // Try to detect if this is a token limit issue
-  if (diffLength > 7000 && diff.match(/\+\+\+ b\/[^\n]*$/m)) {
-    const errorMsg = `Diff appears to be truncated (likely hit token limit). The AI model may have generated an incomplete diff.\n\nErrors:\n${validationResult.errors.join('\n')}\n\nDiff preview (last 500 chars):\n\`\`\`\n${diff.substring(Math.max(0, diffLength - 500))}\n\`\`\`\n\nSuggestion: Try breaking the task into smaller parts or increase max_tokens.`;
+  // Try to detect if this is a token limit or truncation issue
+  // Check for incomplete +++ b/ lines (truncated file paths)
+  const incompletePathMatch = diff.match(/\+\+\+ b\/[^\n]{1,10}$/m);
+  if (incompletePathMatch || (diffLength > 7000 && diff.match(/\+\+\+ b\/[^\n]*$/m))) {
+    const truncationReason = incompletePathMatch 
+      ? "Diff appears to be truncated mid-file-path (model stopped generating)"
+      : "Diff appears to be truncated (likely hit token limit)";
+    const errorMsg = `${truncationReason}. The AI model may have generated an incomplete diff.\n\nErrors:\n${validationResult.errors.join('\n')}\n\nDiff preview (last 500 chars):\n\`\`\`\n${diff.substring(Math.max(0, diffLength - 500))}\n\`\`\`\n\nPossible causes:\n- Model hit output token limit (check max_tokens setting)\n- Low API credits causing early termination\n- Input context too large, leaving insufficient room for output\n- Model stopped generating for other reasons\n\nSuggestions:\n- Check Anthropic account credits\n- Reduce input context size (fewer files)\n- Break task into smaller parts\n- Verify max_tokens is sufficient (currently 180K)`;
     const errorDetails = formatErrorDetails(new Error(errorMsg), { diff: diff.substring(Math.max(0, diffLength - 1000)), files: validationResult.stats.filesChanged });
-    await handleError(new Error(errorMsg), "Incomplete Diff (Token Limit?)", { diff: diff.substring(Math.max(0, diffLength - 1000)), errorDetails });
+    await handleError(new Error(errorMsg), "Incomplete Diff (Truncated)", { diff: diff.substring(Math.max(0, diffLength - 1000)), errorDetails });
     // handleError calls process.exit(1), so we never reach here
   }
 }

.github/workflows/aicode-agent.yml

@@ -76,9 +76,12 @@ jobs:
       - name: Notify Slack on agent failure
         if: steps.agent.outcome != 'success'
         run: |
-          # Use jq to safely construct JSON payload
-          TASK="${{ github.event.client_payload.task || github.event.client_payload.original_task }}"
-          REQUESTER="${{ github.event.client_payload.requester }}"
+          # Write event payload to JSON file to avoid shell quoting issues
+          echo '${{ toJSON(github.event.client_payload) }}' > /tmp/event_payload.json
+          
+          # Extract values using jq (handles all escaping automatically)
+          TASK=$(jq -r '.task // .original_task // "Unknown task"' /tmp/event_payload.json)
+          REQUESTER=$(jq -r '.requester // "unknown"' /tmp/event_payload.json)
           RUN_ID="${{ github.run_id }}"
           
           PAYLOAD=$(jq -n \
@@ -199,10 +202,14 @@ jobs:
       - name: Notify Slack on success
         if: steps.agent.outcome == 'success' && steps.tests.outcome == 'success' && steps.secrets-check.outcome == 'success'
         run: |
+          # Write event payload to JSON file to avoid shell quoting issues
+          echo '${{ toJSON(github.event.client_payload) }}' > /tmp/event_payload.json
+          
+          # Extract values using jq (handles all escaping automatically)
           CHANGED_FILES="${{ steps.changed-files.outputs.files }}"
-          TASK="${{ github.event.client_payload.task || github.event.client_payload.original_task }}"
-          ORIGINAL_TASK="${{ github.event.client_payload.original_task || 'N/A' }}"
-          REQUESTER="${{ github.event.client_payload.requester }}"
+          TASK=$(jq -r '.task // .original_task // "Unknown task"' /tmp/event_payload.json)
+          ORIGINAL_TASK=$(jq -r '.original_task // .task // "N/A"' /tmp/event_payload.json)
+          REQUESTER=$(jq -r '.requester // "unknown"' /tmp/event_payload.json)
           PR_NUMBER="${{ steps.cpr.outputs.pull-request-number }}"
           RUN_ID="${{ github.run_id }}"
           
@@ -241,8 +248,12 @@ jobs:
       - name: Notify Slack on validation failure
         if: steps.agent.outcome == 'success' && steps.secrets-check.outcome != 'success'
         run: |
-          TASK="${{ github.event.client_payload.task || github.event.client_payload.original_task }}"
-          REQUESTER="${{ github.event.client_payload.requester }}"
+          # Write event payload to JSON file to avoid shell quoting issues
+          echo '${{ toJSON(github.event.client_payload) }}' > /tmp/event_payload.json
+          
+          # Extract values using jq (handles all escaping automatically)
+          TASK=$(jq -r '.task // .original_task // "Unknown task"' /tmp/event_payload.json)
+          REQUESTER=$(jq -r '.requester // "unknown"' /tmp/event_payload.json)
           RUN_ID="${{ github.run_id }}"
           
           PAYLOAD=$(jq -n \
@@ -277,8 +288,12 @@ jobs:
       - name: Notify Slack on test failure
         if: steps.agent.outcome == 'success' && steps.secrets-check.outcome == 'success' && steps.tests.outcome != 'success'
         run: |
-          TASK="${{ github.event.client_payload.task || github.event.client_payload.original_task }}"
-          REQUESTER="${{ github.event.client_payload.requester }}"
+          # Write event payload to JSON file to avoid shell quoting issues
+          echo '${{ toJSON(github.event.client_payload) }}' > /tmp/event_payload.json
+          
+          # Extract values using jq (handles all escaping automatically)
+          TASK=$(jq -r '.task // .original_task // "Unknown task"' /tmp/event_payload.json)
+          REQUESTER=$(jq -r '.requester // "unknown"' /tmp/event_payload.json)
           RUN_ID="${{ github.run_id }}"
           
           PAYLOAD=$(jq -n \