Fix workflow job conditions causing skipped executions#206
Merged
Conversation
Remove incorrect 'outcome == success' conditions that were causing jobs to skip even when dependencies succeeded. GitHub Actions automatically skips dependent jobs if their dependencies fail, so explicit conditions are unnecessary. Changes: - Remove 'if: needs.preprocess.outcome == success' from create-confluence - Remove 'if: needs.preprocess.outcome == success' from update-github-issue - Simplify add-comment to only depend on update-github-issue This fixes the issue where all dependent jobs were being skipped despite preprocess completing successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After merging PR #205, all dependent jobs (create-confluence, update-github-issue, add-comment) were being skipped even though the preprocess job completed successfully.
Example failed run: https://github.com/htilly/SlackONOS/actions/runs/20369790629
Root Cause
Using
if: needs.preprocess.outcome == 'success'causes GitHub Actions to skip jobs incorrectly. GitHub Actions documentation states that dependent jobs automatically skip if their dependencies fail, so explicit conditions are unnecessary and can cause unexpected behavior.Solution
Remove the unnecessary
ifconditions:create-confluencejobupdate-github-issuejobadd-commentto only depend onupdate-github-issueTesting
Impact