fix: fixes naming after review

Author: zarram89

js/ui/big-picture/comments.js

@@ -60,13 +60,17 @@ const resetComments = (newComments = []) => {
   commentsLoader.classList.remove('hidden');
 };
 
+const onCommentsLoaderClick = () => {
+  renderComments();
+};
+
 const initCommentsLoader = () => {
   if (isLoaderInitialized) {
     return;
   }
   isLoaderInitialized = true;
 
-  commentsLoader.addEventListener('click', renderComments);
+  commentsLoader.addEventListener('click', onCommentsLoaderClick);
 };
 
 export {

js/ui/form/filter.js

@@ -6,15 +6,15 @@ const Filter = {
   DISCUSSED: 'filter-discussed',
 };
 
-const shuffle = (array) => {
-  const result = [...array];
+const shuffle = (items) => {
+  const shuffledItems = [...items];
 
-  for (let i = result.length - 1; i > 0; i--) {
+  for (let i = shuffledItems.length - 1; i > 0; i--) {
     const j = Math.floor(Math.random() * (i + 1));
-    [result[i], result[j]] = [result[j], result[i]];
+    [shuffledItems[i], shuffledItems[j]] = [shuffledItems[j], shuffledItems[i]];
   }
 
-  return result;
+  return shuffledItems;
 };
 
 const filterPictures = (pictures, filterType) => {

js/ui/form/index.js

@@ -15,11 +15,11 @@ const initForm = () => {
   initScale();
   initEffects();
   initSubmit({
-    success: () => {
+    handleSuccess: () => {
       hideModal();
       showSuccessMessage();
     },
-    error: () => {
+    handleError: () => {
       showErrorMessage();
     },
   });

js/ui/form/modal.js

@@ -35,11 +35,19 @@ const hideModal = () => {
   }
 };
 
+const onFileFieldChange = () => {
+  showModal();
+};
+
+const onCancelButtonClick = () => {
+  hideModal();
+};
+
 const initModal = (cb) => {
   onCloseCallback = cb;
 
-  fileField.addEventListener('change', showModal);
-  cancelButton.addEventListener('click', hideModal);
+  fileField.addEventListener('change', onFileFieldChange);
+  cancelButton.addEventListener('click', onCancelButtonClick);
 };
 
 const isTextFieldFocused = () =>

js/ui/form/submit.js

@@ -41,9 +41,9 @@ const onFormSubmit = async (evt) => {
   }
 };
 
-const initSubmit = ({ success, error }) => {
-  onSuccess = success;
-  onError = error;
+const initSubmit = ({ handleSuccess, handleError }) => {
+  onSuccess = handleSuccess;
+  onError = handleError;
 
   form.addEventListener('submit', onFormSubmit);
 };

js/ui/messages.js

@@ -57,7 +57,11 @@ const showMessage = (template, buttonSelector) => {
     }
   }
 
-  closeButton.addEventListener('click', removeMessage);
+  const onCloseButtonClick = () => {
+    removeMessage();
+  };
+
+  closeButton.addEventListener('click', onCloseButtonClick);
   document.addEventListener('keydown', onKeydown);
   document.addEventListener('click', onOutsideClick);
 };