Skip to content

Commit 96aafe7

Browse files
authored
Merge pull request #16 from NoaVel/master
2 parents f3d82b1 + 436a039 commit 96aafe7

3 files changed

Lines changed: 14 additions & 10 deletions

File tree

js/filters.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ let currentFilter = FilterId.DEFAULT;
1818
let loadedPhotos = [];
1919

2020
const getRandomPhotos = (photos) => {
21-
const shuffled = [...photos];
22-
for (let i = shuffled.length - 1; i > 0; i--) {
21+
const shuffledPhotos = [...photos];
22+
for (let i = shuffledPhotos.length - 1; i > 0; i--) {
2323
const j = Math.floor(Math.random() * (i + 1));
24-
[shuffled[i], shuffled[j]] = [shuffled[j], shuffled[i]];
24+
[shuffledPhotos[i], shuffledPhotos[j]] = [shuffledPhotos[j], shuffledPhotos[i]];
2525
}
26-
return shuffled.slice(0, RANDOM_PHOTOS_COUNT);
26+
return shuffledPhotos.slice(0, RANDOM_PHOTOS_COUNT);
2727
};
2828

2929
const getDiscussedPhotos = (photos) =>

js/render-comments.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,16 @@ const renderNextComments = () => {
4545
}
4646
};
4747

48+
const onCommentsLoaderClick = () => {
49+
renderNextComments();
50+
};
51+
4852
const clearComments = () => {
4953
state.currentCount = 0;
5054
state.comments = [];
5155
socialCommentsNode.innerHTML = '';
5256
commentsLoaderNode.classList.add('hidden');
53-
commentsLoaderNode.removeEventListener('click', renderNextComments);
57+
commentsLoaderNode.removeEventListener('click', onCommentsLoaderClick);
5458
};
5559

5660
const renderComments = (currentPhotoComments) => {
@@ -59,11 +63,11 @@ const renderComments = (currentPhotoComments) => {
5963
socialCommentsNode.innerHTML = '';
6064

6165
commentsCountNode.classList.remove('hidden');
62-
commentsLoaderNode.removeEventListener('click', renderNextComments);
66+
commentsLoaderNode.removeEventListener('click', onCommentsLoaderClick);
6367

6468
if (state.comments.length > COUNT_STEP) {
6569
commentsLoaderNode.classList.remove('hidden');
66-
commentsLoaderNode.addEventListener('click', renderNextComments);
70+
commentsLoaderNode.addEventListener('click', onCommentsLoaderClick);
6771
} else {
6872
commentsLoaderNode.classList.add('hidden');
6973
}

js/upload-photo-form.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ const resetUploadPhotoForm = () => {
6767
resetPreview();
6868
};
6969

70-
const stopEscapePropagation = (evt) => {
70+
const onTextInputKeydown = (evt) => {
7171
if (isEscapeKey(evt)) {
7272
evt.stopPropagation();
7373
}
@@ -184,8 +184,8 @@ const initUploadPhotoForm = () => {
184184
uploadFileControlNode.addEventListener('change', onUploadFileControlChange);
185185
uploadCancelButtonNode.addEventListener('click', onUploadCancelButtonClick);
186186
uploadFormNode.addEventListener('submit', onUploadFormSubmit);
187-
hashtagsInputNode.addEventListener('keydown', stopEscapePropagation);
188-
descriptionInputNode.addEventListener('keydown', stopEscapePropagation);
187+
hashtagsInputNode.addEventListener('keydown', onTextInputKeydown);
188+
descriptionInputNode.addEventListener('keydown', onTextInputKeydown);
189189
};
190190

191191
export { initUploadPhotoForm };

0 commit comments

Comments
 (0)