Skip to content

Commit cc418c4

Browse files
Merge pull request #11 from htmlprogrammist/develop
3.0.7
2 parents 1d2cc6b + 75c1da3 commit cc418c4

12 files changed

Lines changed: 387 additions & 389 deletions

File tree

CONTRIBUTING.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,11 @@ If you can't find valid, add new to codestyle agreements please. Other can be us
8484
docs: update readme with additional information
8585
docs: update description of run() method
8686
```
87+
88+
## Before making pull request
89+
90+
1. Change version in [`EmojiPicker.podspec`](/EmojiPicker.podspec) file
91+
2. Update version of dependency in Example App:
92+
1. Open terminal
93+
2. Open Example app directory using `cd Example\ App/`
94+
3. Update pod version via command `pod install`

EmojiPicker.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'EmojiPicker'
3-
s.version = '3.0.4'
3+
s.version = '3.0.7'
44
s.license = 'MIT'
55
s.summary = 'Emoji picker for iOS like on MacOS'
66
s.homepage = 'https://github.com/htmlprogrammist/EmojiPicker'
Binary file not shown.

Example App/Podfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
PODS:
2-
- EmojiPicker (3.0.4)
3-
- EmojiPicker/Tests (3.0.4)
2+
- EmojiPicker (3.0.7)
3+
- EmojiPicker/Tests (3.0.7)
44

55
DEPENDENCIES:
66
- EmojiPicker (from `../`)
@@ -11,7 +11,7 @@ EXTERNAL SOURCES:
1111
:path: "../"
1212

1313
SPEC CHECKSUMS:
14-
EmojiPicker: a21d785c95a64a0284b0d1472150d90c4348d5e3
14+
EmojiPicker: 296cacb36c0eb34fe978d5411eaa06a67cd6da4b
1515

1616
PODFILE CHECKSUM: e686a8fbd8a5367eac0bf7fb77e0bbddf18a2353
1717

Example App/Pods/Local Podspecs/EmojiPicker.podspec.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Example App/Pods/Manifest.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Example App/Pods/Pods.xcodeproj/project.pbxproj

Lines changed: 338 additions & 334 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Example App/Pods/Target Support Files/EmojiPicker/EmojiPicker-Info.plist

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Example App/Pods/Target Support Files/EmojiPicker/ResourceBundle-Resources-EmojiPicker-Info.plist

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Sources/EmojiPicker/Services/EmojiManager.swift

Lines changed: 28 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,10 @@
1919
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2020
// SOFTWARE.
2121

22-
import UIKit.UIDevice
22+
import UIKit
2323

24+
/// An abstraction over entity that provides emoji set.
2425
protocol EmojiManagerProtocol {
25-
26-
/// Operating System version of a device.
27-
var deviceVersion: Double { get }
28-
2926
/// Gets version of iOS for current device.
3027
///
3128
/// - Returns: Array of emoji categories (and array of emojis inside them).
@@ -37,21 +34,41 @@ final class EmojiManager: EmojiManagerProtocol {
3734

3835
// MARK: - Private Properties
3936

37+
/// An object that decodes instances of a data type from JSON objects.
4038
private let decoder = JSONDecoder()
39+
4140
/// Version of emoji set.
4241
///
4342
/// - Note: The value is `5` by default.
44-
private var emojiVersion = "5"
45-
46-
// MARK: - Internal
43+
private var emojiVersion: String {
44+
switch deviceVersion {
45+
case 12.1...13.1:
46+
return "11"
47+
48+
case 13.2...14.1:
49+
return "12.1"
50+
51+
case 14.2...14.4:
52+
return "13"
53+
54+
case 14.5...15.3:
55+
return "13.1"
56+
57+
case 15.4...:
58+
return "14"
59+
60+
default:
61+
return "5"
62+
}
63+
}
4764

48-
var deviceVersion: Double {
65+
private var deviceVersion: Double {
4966
return (UIDevice.current.systemVersion as NSString).doubleValue
5067
}
5168

69+
// MARK: - Internal Methods
70+
5271
func provideEmojis() -> EmojiSet {
53-
setEmojiVersion()
54-
5572
guard let path = Bundle.module.path(forResource: emojiVersion, ofType: "json"),
5673
let data = try? Data(contentsOf: URL(fileURLWithPath: path))
5774
else {
@@ -65,28 +82,4 @@ final class EmojiManager: EmojiManagerProtocol {
6582

6683
return emojiSet
6784
}
68-
69-
// MARK: - Private Methods
70-
71-
private func setEmojiVersion() {
72-
switch deviceVersion {
73-
case 12.1...13.1:
74-
emojiVersion = "11"
75-
76-
case 13.2...14.1:
77-
emojiVersion = "12.1"
78-
79-
case 14.2...14.4:
80-
emojiVersion = "13"
81-
82-
case 14.5...15.3:
83-
emojiVersion = "13.1"
84-
85-
case 15.4...:
86-
emojiVersion = "14"
87-
88-
default:
89-
emojiVersion = "5"
90-
}
91-
}
9285
}

0 commit comments

Comments
 (0)