Display a FAILED message in the FunctionBar on host scan failure

Implements review feedback from BenBE, suggesting to show when a
PCP metrics collection daemon (pmcd) is restarted/stopped and we
cannot retrieve latest values as a result.  This uses the method
employed to display PAUSED updates, which is given preference in
the case where both are true.

Author: natoscott

Action.h

@@ -37,6 +37,7 @@ typedef struct State_ {
    struct MainPanel_* mainPanel;
    Header* header;
    bool pauseUpdate;
+   bool validUpdate;
    bool hideSelection;
    bool hideMeters;
 } State;

CommandLine.c

@@ -378,6 +378,7 @@ int CommandLine_run(int argc, char** argv) {
       .mainPanel = panel,
       .header = header,
       .pauseUpdate = false,
+      .validUpdate = true,
       .hideSelection = false,
       .hideMeters = false,
    };

MainPanel.c

@@ -194,6 +194,8 @@ static void MainPanel_drawFunctionBar(Panel* super, bool hideFunctionBar) {
    IncSet_drawBar(this->inc, CRT_colors[FUNCTION_BAR]);
    if (this->state->pauseUpdate) {
       FunctionBar_append("PAUSED", CRT_colors[PAUSED]);
+   } else if (!this->state->validUpdate) {
+      FunctionBar_append("FAILED", CRT_colors[FAILED_READ]);
    }
 }
 

ScreenManager.c

@@ -147,6 +147,7 @@ static void checkRecalculation(ScreenManager* this, double* oldTime, int* sortTi
       Machine_scan(host);
       if (!this->state->pauseUpdate)
          Machine_scanTables(host);
+      this->state->validUpdate = Platform_getValidState();
 
       // always update header, especially to avoid gaps in graph meters
       Header_updateData(this->header);

darwin/Platform.h

@@ -88,6 +88,10 @@ static inline void Platform_getRelease(char** string) {
    *string = Generic_uname();
 }
 
+static inline bool Platform_getValidState(void) {
+   return true;
+}
+
 #define PLATFORM_LONG_OPTIONS
 
 static inline void Platform_longOptionsUsage(ATTR_UNUSED const char* name) { }

dragonflybsd/Platform.h

@@ -77,6 +77,10 @@ static inline void Platform_getRelease(char** string) {
    *string = Generic_uname();
 }
 
+static inline bool Platform_getValidState(void) {
+   return true;
+}
+
 #define PLATFORM_LONG_OPTIONS
 
 static inline void Platform_longOptionsUsage(ATTR_UNUSED const char* name) { }

freebsd/Platform.h

@@ -77,6 +77,10 @@ static inline void Platform_getRelease(char** string) {
    *string = Generic_uname();
 }
 
+static inline bool Platform_getValidState(void) {
+   return true;
+}
+
 #define PLATFORM_LONG_OPTIONS
 
 static inline void Platform_longOptionsUsage(ATTR_UNUSED const char* name) { }

linux/Platform.h

@@ -98,6 +98,10 @@ static inline void Platform_getRelease(char** string) {
    *string = Generic_uname();
 }
 
+static inline bool Platform_getValidState(void) {
+   return true;
+}
+
 #ifdef HAVE_LIBCAP
    #define PLATFORM_LONG_OPTIONS \
       {"drop-capabilities", optional_argument, 0, 160},

netbsd/Platform.h

@@ -83,6 +83,10 @@ static inline void Platform_getRelease(char** string) {
    *string = Generic_uname();
 }
 
+static inline bool Platform_getValidState(void) {
+   return true;
+}
+
 static inline void Platform_longOptionsUsage(ATTR_UNUSED const char* name) { }
 
 static inline CommandLineStatus Platform_getLongOption(ATTR_UNUSED int opt, ATTR_UNUSED int argc, ATTR_UNUSED char** argv) {

openbsd/Platform.h

@@ -75,6 +75,10 @@ static inline void Platform_getRelease(char** string) {
    *string = Generic_uname();
 }
 
+static inline bool Platform_getValidState(void) {
+   return true;
+}
+
 #define PLATFORM_LONG_OPTIONS
 
 static inline void Platform_longOptionsUsage(ATTR_UNUSED const char* name) { }