Merge pull request #1919 from Explorer09/fdpair-init

pipe() & fork() code quality improvements

Author: BenBE

OpenFilesScreen.c

@@ -100,14 +100,14 @@ static OpenFiles_ProcessData* OpenFilesScreen_getProcessData(pid_t pid) {
    pdata->cols[getIndexForType('o')] = 8;
    pdata->cols[getIndexForType('i')] = 8;
 
-   int fdpair[2] = {0, 0};
-   if (pipe(fdpair) == -1) {
+   int fdpair[2] = {-1, -1};
+   if (pipe(fdpair) < 0) {
       pdata->error = 1;
       return pdata;
    }
 
    pid_t child = fork();
-   if (child == -1) {
+   if (child < 0) {
       close(fdpair[1]);
       close(fdpair[0]);
       pdata->error = 1;

TraceScreen.c

@@ -67,9 +67,9 @@ static void TraceScreen_draw(InfoScreen* this) {
 }
 
 bool TraceScreen_forkTracer(TraceScreen* this) {
-   int fdpair[2] = {0, 0};
+   int fdpair[2] = {-1, -1};
 
-   if (pipe(fdpair) == -1)
+   if (pipe(fdpair) < 0)
       return false;
 
    if (fcntl(fdpair[0], F_SETFL, O_NONBLOCK) < 0)
@@ -79,7 +79,7 @@ bool TraceScreen_forkTracer(TraceScreen* this) {
       goto err;
 
    pid_t child = fork();
-   if (child == -1)
+   if (child < 0)
       goto err;
 
    if (child == 0) {

linux/OpenRCMeter.c

@@ -48,7 +48,7 @@ static void updateViaExec(bool user) {
    if (Settings_isReadonly())
       return;
 
-   int fdpair[2];
+   int fdpair[2] = {-1, -1};
    if (pipe(fdpair) < 0)
       return;
 

linux/SystemdMeter.c

@@ -217,7 +217,7 @@ static void updateViaExec(bool user) {
    if (Settings_isReadonly())
       return;
 
-   int fdpair[2];
+   int fdpair[2] = {-1, -1};
    if (pipe(fdpair) < 0)
       return;