“Security Attribute” column width mismatch between table header and body

[lucaswerkmeister]

When the SECATTR column is added to htop, it’s much wider in the actual table than in the header, which means that all the header columns following it are misaligned.

 Security Attribute     PID△USER       NI  VIRT   RES   SHR S CPU% MEM%   TIME+  Command                                                                                                                                                                                                              
?                                      1 root        0  161M 11780  8600 S  0.0  0.0  0:01.56 /usr/lib/systemd/systemd --switched-root --system --deserialize 31                                                                                                                                      
?                                    681 root        0  126M 62724 61216 S  0.0  0.2  0:02.19 ├─ /usr/lib/systemd/systemd-journald

This also happens when the column is in another position, though I haven’t tested all possibilities.

    PID△USER       NI  VIRT   RES   SHR  Security Attribute S CPU% MEM%   TIME+  Command                                                                                                                                                                                                              
      1 root        0  161M 11784  8600 ?                                S  0.0  0.0  0:01.56 /usr/lib/systemd/systemd --switched-root --system --deserialize 31                                                                                                                                      

This could be just because I don’t use SELinux/AppArmor/etc. and there aren’t any attributes to show, I don’t know.

OS: Arch Linux
htop: 3.1.1, but issue discovered while testing #849, so probably still present in main

[BenBE]

Please test the following patch:

diff --git a/linux/LinuxProcess.c b/linux/LinuxProcess.c
index 6bbd3d65..dfa49807 100644
--- a/linux/LinuxProcess.c
+++ b/linux/LinuxProcess.c
@@ -93,7 +93,7 @@ const ProcessFieldData Process_fields[LAST_PROCESSFIELD] = {
    [M_SWAP] = { .name = "M_SWAP", .title = " SWAP ", .description = "Size of the process's swapped pages", .flags = PROCESS_FLAG_LINUX_SMAPS, .defaultSortDesc = true, },
    [M_PSSWP] = { .name = "M_PSSWP", .title = " PSSWP ", .description = "shows proportional swap share of this mapping, unlike \"Swap\", this does not take into account swapped out page of underlying shmem objects", .flags = PROCESS_FLAG_LINUX_SMAPS, .defaultSortDesc = true, },
    [CTXT] = { .name = "CTXT", .title = " CTXT ", .description = "Context switches (incremental sum of voluntary_ctxt_switches and nonvoluntary_ctxt_switches)", .flags = PROCESS_FLAG_LINUX_CTXT, .defaultSortDesc = true, },
-   [SECATTR] = { .name = "SECATTR", .title = " Security Attribute ", .description = "Security attribute of the process (e.g. SELinux or AppArmor)", .flags = PROCESS_FLAG_LINUX_SECATTR, },
+   [SECATTR] = { .name = "SECATTR", .title = " Security Attribute            ", .description = "Security attribute of the process (e.g. SELinux or AppArmor)", .flags = PROCESS_FLAG_LINUX_SECATTR, },
    [PROC_COMM] = { .name = "COMM", .title = "COMM            ", .description = "comm string of the process from /proc/[pid]/comm", .flags = 0, },
    [PROC_EXE] = { .name = "EXE", .title = "EXE             ", .description = "Basename of exe of the process from /proc/[pid]/exe", .flags = 0, },
    [CWD] = { .name = "CWD", .title = "CWD                       ", .description = "The current working directory of the process", .flags = PROCESS_FLAG_CWD, },
@@ -278,7 +278,7 @@ static void LinuxProcess_writeField(const Process* this, RichString* str, Proces
       }
       xSnprintf(buffer, n, "%5lu ", lp->ctxt_diff);
       break;
-   case SECATTR: snprintf(buffer, n, "%-30s   ", lp->secattr ? lp->secattr : "?"); break;
+   case SECATTR: snprintf(buffer, n, "%-30.30s   ", lp->secattr ? lp->secattr : "?"); break;
    case AUTOGROUP_ID:
       if (lp->autogroup_id != -1) {
          xSnprintf(buffer, n, "%4ld ", lp->autogroup_id);

[lucaswerkmeister]

I tested the following:

diff --git a/linux/LinuxProcess.c b/linux/LinuxProcess.c
index 6bbd3d6..1f505db 100644
--- a/linux/LinuxProcess.c
+++ b/linux/LinuxProcess.c
@@ -93,7 +93,7 @@ const ProcessFieldData Process_fields[LAST_PROCESSFIELD] = {
    [M_SWAP] = { .name = "M_SWAP", .title = " SWAP ", .description = "Size of the process's swapped pages", .flags = PROCESS_FLAG_LINUX_SMAPS, .defaultSortDesc = true, },
    [M_PSSWP] = { .name = "M_PSSWP", .title = " PSSWP ", .description = "shows proportional swap share of this mapping, unlike \"Swap\", this does not take into account swapped out page of underlying shmem objects", .flags = PROCESS_FLAG_LINUX_SMAPS, .defaultSortDesc = true, },
    [CTXT] = { .name = "CTXT", .title = " CTXT ", .description = "Context switches (incremental sum of voluntary_ctxt_switches and nonvoluntary_ctxt_switches)", .flags = PROCESS_FLAG_LINUX_CTXT, .defaultSortDesc = true, },
-   [SECATTR] = { .name = "SECATTR", .title = " Security Attribute ", .description = "Security attribute of the process (e.g. SELinux or AppArmor)", .flags = PROCESS_FLAG_LINUX_SECATTR, },
+   [SECATTR] = { .name = "SECATTR", .title = " Security Attribute              ", .description = "Security attribute of the process (e.g. SELinux or AppArmor)", .flags = PROCESS_FLAG_LINUX_SECATTR, },
    [PROC_COMM] = { .name = "COMM", .title = "COMM            ", .description = "comm string of the process from /proc/[pid]/comm", .flags = 0, },
    [PROC_EXE] = { .name = "EXE", .title = "EXE             ", .description = "Basename of exe of the process from /proc/[pid]/exe", .flags = 0, },
    [CWD] = { .name = "CWD", .title = "CWD                       ", .description = "The current working directory of the process", .flags = PROCESS_FLAG_CWD, },
@@ -278,7 +278,7 @@ static void LinuxProcess_writeField(const Process* this, RichString* str, Proces
       }
       xSnprintf(buffer, n, "%5lu ", lp->ctxt_diff);
       break;
-   case SECATTR: snprintf(buffer, n, "%-30s   ", lp->secattr ? lp->secattr : "?"); break;
+   case SECATTR: snprintf(buffer, n, "%-30.30s   ", lp->secattr ? lp->secattr : "?"); break;
    case AUTOGROUP_ID:
       if (lp->autogroup_id != -1) {
          xSnprintf(buffer, n, "%4ld ", lp->autogroup_id);

Let me reset that and see if yours is the same ^^

[lucaswerkmeister]

Hm, I think your patch doesn’t quite have the right number of spaces. (I also first padded it to 30, but with that it was still off by a bit.)

With your patch:

 Security Attribute                PID△USER       NI  VIRT   RES   SHR S CPU% MEM%   TIME+  Command                                                                                                                                                                                                   
?                                      1 root        0  161M 11784  8600 S  0.0  0.0  0:01.57 /usr/lib/systemd/systemd --switched-root --system --deserialize 31                                                                                                                                      

With mine (two spaces more):

 Security Attribute                  PID△USER       NI  VIRT   RES   SHR S CPU% MEM%   TIME+  Command                                                                                                                                                                                                 
?                                      1 root        0  161M 11784  8600 S  0.0  0.0  0:01.57 /usr/lib/systemd/systemd --switched-root --system --deserialize 31                                                                                                                                      

Not sure why two spaces more would be required.

[BenBE]

The two additional spaces come from the 3 blanks instead of the usual one in the format string (2nd hunk); reduce to one blank there and mine should fit.

[lucaswerkmeister]

Ah, or this:

diff --git a/linux/LinuxProcess.c b/linux/LinuxProcess.c
index 6bbd3d6..5c6dcc2 100644
--- a/linux/LinuxProcess.c
+++ b/linux/LinuxProcess.c
@@ -93,7 +93,7 @@ const ProcessFieldData Process_fields[LAST_PROCESSFIELD] = {
    [M_SWAP] = { .name = "M_SWAP", .title = " SWAP ", .description = "Size of the process's swapped pages", .flags = PROCESS_FLAG_LINUX_SMAPS, .defaultSortDesc = true, },
    [M_PSSWP] = { .name = "M_PSSWP", .title = " PSSWP ", .description = "shows proportional swap share of this mapping, unlike \"Swap\", this does not take into account swapped out page of underlying shmem objects", .flags = PROCESS_FLAG_LINUX_SMAPS, .defaultSortDesc = true, },
    [CTXT] = { .name = "CTXT", .title = " CTXT ", .description = "Context switches (incremental sum of voluntary_ctxt_switches and nonvoluntary_ctxt_switches)", .flags = PROCESS_FLAG_LINUX_CTXT, .defaultSortDesc = true, },
-   [SECATTR] = { .name = "SECATTR", .title = " Security Attribute ", .description = "Security attribute of the process (e.g. SELinux or AppArmor)", .flags = PROCESS_FLAG_LINUX_SECATTR, },
+   [SECATTR] = { .name = "SECATTR", .title = " Security Attribute            ", .description = "Security attribute of the process (e.g. SELinux or AppArmor)", .flags = PROCESS_FLAG_LINUX_SECATTR, },
    [PROC_COMM] = { .name = "COMM", .title = "COMM            ", .description = "comm string of the process from /proc/[pid]/comm", .flags = 0, },
    [PROC_EXE] = { .name = "EXE", .title = "EXE             ", .description = "Basename of exe of the process from /proc/[pid]/exe", .flags = 0, },
    [CWD] = { .name = "CWD", .title = "CWD                       ", .description = "The current working directory of the process", .flags = PROCESS_FLAG_CWD, },
@@ -278,7 +278,7 @@ static void LinuxProcess_writeField(const Process* this, RichString* str, Proces
       }
       xSnprintf(buffer, n, "%5lu ", lp->ctxt_diff);
       break;
-   case SECATTR: snprintf(buffer, n, "%-30s   ", lp->secattr ? lp->secattr : "?"); break;
+   case SECATTR: snprintf(buffer, n, "%-30.30s ", lp->secattr ? lp->secattr : "?"); break;
    case AUTOGROUP_ID:
       if (lp->autogroup_id != -1) {
          xSnprintf(buffer, n, "%4ld ", lp->autogroup_id);

(Less spaces in the snprintf.)

 Security Attribute                PID△USER       NI  VIRT   RES   SHR S CPU% MEM%   TIME+  Command                                                                                                                                                                                                   
?                                    1 root        0  161M 11788  8600 S  0.0  0.0  0:01.57 /usr/lib/systemd/systemd --switched-root --system --deserialize 31