Normalize physical core ID when showCPUSMTLabels is set#1940
Merged
natoscott merged 3 commits intohtop-dev:mainfrom Apr 6, 2026
Merged
Normalize physical core ID when showCPUSMTLabels is set#1940natoscott merged 3 commits intohtop-dev:mainfrom
showCPUSMTLabels is set#1940natoscott merged 3 commits intohtop-dev:mainfrom
Conversation
Explorer09
reviewed
Apr 5, 2026
Explorer09
reviewed
Apr 5, 2026
3e0d0da to
d515e2e
Compare
Explorer09
reviewed
Apr 5, 2026
Co-authored-by: Kang-Che Sung (宋岡哲) <Explorer09@gmail.com>
d515e2e to
c616371
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR normalizes the physical core IDs used when the
showCPUSMTLabelsoption is set.Changes
coreIndexinLinuxMachinewhich tracks normalized IDcoreIndexinMachine_getCPUPhysicalCoreID()Motivation
This fixes the IDs displayed on systems with non-contiguous core IDs such as the xeon system that @lilydjwg tested on in #1902
cpuinfo.txt
Future Work
It would be cool to have a mode that renders the CPU IDs as
socket.core.thread, but this requires more than the three characters of space currently available.