Conversation
Contributor
Author
|
A contribution was made 3 years ago (#811) aiming to fix this issue. Since the PR was not merged in the time being, based on experience, it is very difficult to revive it (contributors move on, context is lost, ...). So I decided to submit a new PR that fixes this issue and close the old one. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 18+ changed the
os.networkInterfaces()API to return numeric family values (4, 6) instead of strings ('IPv4', 'IPv6'). This caused the server startup message to not display any available network addresses on newer Node versions.This PR updates the interface filtering logic to handle both string and numeric family formats, ensuring compatibility across all Node.js versions.
Changes:
'IPv4'and4as valid family valuesRelevant issues
Fixes #810
Contributor checklist
--helpoutputmasterbranch