fix: fail fast on --password without --user#937
Merged
KernelDeimos merged 2 commits intomasterfrom Nov 29, 2025
Merged
Conversation
When passing a password without a username, http-server will launch successfully but the first request with an Authorization header will crash the server. This behavior is very inconvenient. This commit makes it fail fast instead so you know there's a problem before you log out of SSH or walk out of the house or office. Also alised `--user` to `--username` for added convenience. Resolves #935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing a password without a username, http-server will launch successfully but the first request with an Authorization header will crash the server. This behavior is very inconvenient. This commit makes it fail fast instead so you know there's a problem before you log out of SSH or walk out of the house or office. Also alised
--userto--usernamefor added convenience.Resolves #935
Relevant issues
Contributor checklist
Provide tests for the changes (unless documentation-only)(automated testing is not worth it here; manually tested)--helpoutputmasterbranchMaintainer checklist