crash when 'options.target' is an object instead a string#1600
Open
vilherda wants to merge 1 commit intohttp-party:masterfrom
Open
crash when 'options.target' is an object instead a string#1600vilherda wants to merge 1 commit intohttp-party:masterfrom
vilherda wants to merge 1 commit intohttp-party:masterfrom
Conversation
Sometimes the attribute 'options.target' is not a string and is an object like:
```json
{
"protocol": "http:",
"slashes": true,
"auth": null,
"host": "some.hostname.fake",
"port": null,
"hostname": "some.hostname.fake",
"hash": null,
"search": null,
"query": null,
"pathname": "/",
"path": "/",
"href": "http://some.hostname.fake"
}
```
In this case is necessary to access to the attribute 'options.target.href'.
Cuadrix
approved these changes
Oct 18, 2022
58 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
When `options.target` is a `ProxyTargetDetailed` object (not a string or URL), `setRedirectHostRewrite` crashed with `Invalid URL` because `new URL()` cannot parse a plain object. Construct the URL from the object's `protocol`, `host`/`hostname`, and `port` properties instead. Upstream: http-party/node-http-proxy#1600
3 tasks
pi0
added a commit
to unjs/httpxy
that referenced
this pull request
Mar 25, 2026
When `options.target` is a `ProxyTargetDetailed` object (not a string or URL), `setRedirectHostRewrite` crashed with `Invalid URL` because `new URL()` cannot parse a plain object. Construct the URL from the object's `protocol`, `host`/`hostname`, and `port` properties instead. Upstream: http-party/node-http-proxy#1600
|
This issue has been fixed in unjs/httpxy#108. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the attribute 'options.target' is not a string and is an object like:
{ "protocol": "http:", "slashes": true, "auth": null, "host": "some.hostname.fake", "port": null, "hostname": "some.hostname.fake", "hash": null, "search": null, "query": null, "pathname": "/", "path": "/", "href": "http://some.hostname.fake" }In this case is necessary to access to the attribute 'options.target.href'.