Introduce multi-part pair spec

Author: Matt Kelly

lib/http/form_data/multipart.rb

@@ -16,7 +16,7 @@ class Multipart
 
       # @param [#to_h, Hash] data form data key-value Hash
       def initialize(data, boundary: self.class.generate_boundary)
-        parts = Param.coerce FormData.ensure_hash data
+        parts = Param.coerce FormData.ensure_hash data unless @params.is_a?(Array)
 
         @boundary = boundary.to_s.freeze
         @io = CompositeIO.new [*parts.flat_map { |part| [glue, part] }, tail]
@@ -54,6 +54,14 @@ def glue
       def tail
         @tail ||= "--#{@boundary}--#{CRLF}"
       end
+
+      def join_multipart_pairs(pairs)
+        pairs.each_cons(2).each do |pair|
+          multipart = pair.first
+          file = pair.last
+
+        end
+      end
     end
   end
 end

spec/lib/http/form_data/multipart_spec.rb

@@ -87,6 +87,30 @@ def disposition(params)
         ].join)
       end
     end
+
+    # https://github.com/httprb/http/issues/663
+    context "when params is a list of pairs" do
+      let(:params) do
+        [
+          ["metadata", %(filename=first.txt)],
+          ["file", HTTP::FormData::File.new(StringIO.new("uno"), :content_type => 'plain/text', :filename => "stream-123")],
+          ["metadata", %(filename=second.txt)],
+          ["file", HTTP::FormData::File.new(StringIO.new("dos"), :content_type => 'plain/text', :filename => "stream-456")]
+        ]
+      end
+
+      it "allows duplicate param names and preservesd given order" do
+        # form_data.boundary
+
+        expect(form_data.to_s).to eq([
+          %(--#{form_data.boundary}#{crlf}),
+          %(Content-Disposition: form-data; name="metadata"#{crlf}#{crlf}),
+          %(filename=first.txt#{crlf}),
+          %(--#{form_data.boundary}#{crlf}),
+          %(--#{boundary_value}--#{crlf})
+        ].join)
+      end
+    end
   end
 
   describe "#size" do