Remove unused HTTP::URI delegations to Addressable::URI

Remove setters (scheme=, user=, password=, authority=, origin=, port=,
request_uri=, fragment=) and normalized accessors (normalized_user,
normalized_password, normalized_port, normalized_path, normalized_query)
that are never called outside of HTTP::URI. This reduces the public API
surface that leaks Addressable semantics, preparing for an eventual
removal of the Addressable dependency.

Author: sferik

CHANGELOG.md

@@ -67,6 +67,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   body chunks are now logged as they are streamed, preserving
   `response.body.each` (#785)
 
+### Removed
+
+- `HTTP::URI` setter methods (`scheme=`, `user=`, `password=`, `authority=`,
+  `origin=`, `port=`, `request_uri=`, `fragment=`) and normalized accessors
+  (`normalized_user`, `normalized_password`, `normalized_port`,
+  `normalized_path`, `normalized_query`) that were delegated to
+  `Addressable::URI` but never used internally
+
 ### Changed
 
 - **BREAKING** `HTTP::Response::Status` no longer inherits from `Delegator`.

lib/http/uri.rb

@@ -10,17 +10,16 @@ class URI
     # The URI given was not valid
     class InvalidError < HTTP::RequestError; end
 
-    def_delegators :@uri, :scheme, :normalized_scheme, :scheme=
-    def_delegators :@uri, :user, :normalized_user, :user=
-    def_delegators :@uri, :password, :normalized_password, :password=
-    def_delegators :@uri, :authority, :normalized_authority, :authority=
-    def_delegators :@uri, :origin, :origin=
-    def_delegators :@uri, :normalized_port, :port=
-    def_delegators :@uri, :path, :normalized_path, :path=
-    def_delegators :@uri, :query, :normalized_query, :query=
+    def_delegators :@uri, :scheme, :normalized_scheme
+    def_delegators :@uri, :user
+    def_delegators :@uri, :password
+    def_delegators :@uri, :authority, :normalized_authority
+    def_delegators :@uri, :origin
+    def_delegators :@uri, :path, :path=
+    def_delegators :@uri, :query, :query=
     def_delegators :@uri, :query_values, :query_values=
-    def_delegators :@uri, :request_uri, :request_uri=
-    def_delegators :@uri, :fragment, :normalized_fragment, :fragment=
+    def_delegators :@uri, :request_uri
+    def_delegators :@uri, :fragment, :normalized_fragment
     def_delegators :@uri, :omit, :join, :normalize
 
     # Host, either a domain name or IP address

sig/http.rbs

@@ -600,28 +600,19 @@ module HTTP
 
     # Delegated methods from Addressable::URI
     def scheme: () -> String?
-    def scheme=: (String?) -> String?
     def normalized_scheme: () -> String?
     def normalized_authority: () -> String?
     def user: () -> String?
-    def user=: (String?) -> String?
     def password: () -> String?
-    def password=: (String?) -> String?
-    def normalized_port: () -> Integer?
-    def port=: (Integer?) -> Integer?
     def path: () -> String
     def path=: (String) -> String
-    def normalized_path: () -> String
     def query: () -> String?
     def query=: (String?) -> String?
     def query_values: (?untyped notation) -> untyped
     def query_values=: (untyped) -> untyped
-    def normalized_query: () -> String?
     def request_uri: () -> String
-    def request_uri=: (String) -> String
     def fragment: () -> String?
     def normalized_fragment: () -> String?
-    def fragment=: (String?) -> String?
     def omit: (*Symbol) -> URI
     def join: (String | URI) -> URI
     def normalize: () -> URI

test/http_test.rb

@@ -753,13 +753,12 @@ def setsockopt(*args)
 
       it "raises if custom URI Normalizer returns invalid host" do
         normalizer = lambda do |uri|
-          uri.port = nil
           uri.instance_variable_set(:@host, "example\ncom")
           uri
         end
         client = HTTP.use(normalize_uri: { normalizer: normalizer })
         err = assert_raises(HTTP::RequestError) { client.get(dummy.endpoint) }
-        assert_equal 'Invalid host: "example\ncom"', err.message
+        assert_match(/Invalid host: "example\\ncom/, err.message)
       end
 
       it "uses the default URI normalizer" do