Switch mutant operators from light to full and kill surviving mutants

sferik · sferik · commit da374efefa99 · 2026-03-16T13:24:54.000-07:00
diff --git a/.mutant.yml b/.mutant.yml
@@ -14,6 +14,7 @@ requires:
   - http
 
 mutation:
+  operators: full
   timeout: 10.0
 
 matcher:
diff --git a/lib/http/features/caching.rb b/lib/http/features/caching.rb
@@ -70,7 +70,7 @@ def around_request(request)
 
         response = yield(add_conditional_headers(request, entry))
 
-        return revalidate_entry(entry, response, request) if response.code == 304
+        return revalidate_entry(entry, response, request) if response.status.not_modified?
 
         response
       end
diff --git a/lib/http/features/logging.rb b/lib/http/features/logging.rb
@@ -104,7 +104,7 @@ def wrap_response(response)
       # @raise [ArgumentError] if the formatter is not a valid option
       # @api private
       def validate_binary_formatter!(formatter)
-        return formatter if formatter == :stats || formatter == :base64 || formatter.respond_to?(:call)
+        return formatter if formatter.eql?(:stats) || formatter.eql?(:base64) || formatter.respond_to?(:call)
 
         raise ArgumentError,
               "binary_formatter must be :stats, :base64, or a callable " \
@@ -118,7 +118,7 @@ def log_request_details(request)
         headers = stringify_headers(request.headers)
         if request.body.loggable?
           source = request.body.source
-          body = source.encoding == Encoding::BINARY ? format_binary(source) : source
+          body = source.encoding.eql?(Encoding::BINARY) ? format_binary(source) : source
           logger.debug { "#{headers}\n\n#{body}" }
         else
           logger.debug { headers }
@@ -131,7 +131,7 @@ def log_request_details(request)
       def log_response_body_inline(response)
         body    = response.body
         headers = stringify_headers(response.headers)
-        if body.respond_to?(:encoding) && body.encoding == Encoding::BINARY
+        if body.respond_to?(:encoding) && body.encoding.eql?(Encoding::BINARY)
           logger.debug { "#{headers}\n\n#{format_binary(body)}" } # steep:ignore
         else
           logger.debug { "#{headers}\n\n#{body}" }
diff --git a/lib/http/headers.rb b/lib/http/headers.rb
@@ -104,7 +104,7 @@ def set(name, value)
     # @api public
     def delete(name)
       name = normalize_header name
-      @pile.delete_if { |k, _| k == name }
+      @pile.delete_if { |k, _| k.eql?(name) }
     end
 
     # Appends header value(s) to the given name
@@ -143,7 +143,7 @@ def add(name, value)
     # @api public
     def get(name)
       name = normalize_header name
-      @pile.select { |k, _| k == name }.map { |_, _, v| v }
+      @pile.select { |k, _| k.eql?(name) }.map { |_, _, v| v }
     end
 
     # Smart version of {#get}
@@ -159,7 +159,9 @@ def [](name)
       values = get(name)
       return if values.empty?
 
-      values.one? ? values.first : values
+      return values unless values.one?
+
+      values.join
     end
 
     # Tells whether header with given name is set
@@ -171,7 +173,7 @@ def [](name)
     # @api public
     def include?(name)
       name = normalize_header name
-      @pile.any? { |k, _| k == name }
+      @pile.any? { |k, _| k.eql?(name) }
     end
 
     # Returns Rack-compatible headers Hash
@@ -232,7 +234,7 @@ def keys
     def ==(other)
       return false unless other.respond_to? :to_a
 
-      to_a == other.to_a
+      to_a.eql?(other.to_a)
     end
 
     # Calls the given block once for each key/value pair
diff --git a/lib/http/options.rb b/lib/http/options.rb
@@ -221,7 +221,7 @@ def feature(name)
     def assign_options(env)
       self.class.defined_options.each do |name|
         value = env.local_variable_get(name)
-        value = Headers.coerce(value) if name == :headers
+        value = Headers.coerce(value) if name.eql?(:headers)
         __send__(:"#{name}=", value)
       end
     end
diff --git a/lib/http/options/definitions.rb b/lib/http/options/definitions.rb
@@ -178,7 +178,7 @@ def validate_base_uri_and_persistent!
       base = @base_uri
       persistent = @persistent
       return unless base && persistent
-      return if base.origin == persistent
+      return if base.origin.eql?(persistent)
 
       argument_error!(
         format("Persistence origin (%s) conflicts with base URI origin (%s)",
diff --git a/lib/http/redirector.rb b/lib/http/redirector.rb
@@ -149,7 +149,7 @@ def redirect_to(uri)
         verb = :get
       end
 
-      verb = :get if !SEE_OTHER_ALLOWED_VERBS.include?(verb) && 303 == code
+      verb = :get if !SEE_OTHER_ALLOWED_VERBS.include?(verb) && code.eql?(303)
 
       @request.redirect(uri, verb)
     end
diff --git a/lib/http/request/writer.rb b/lib/http/request/writer.rb
@@ -160,7 +160,7 @@ def encode_chunk(chunk)
       # @return [Boolean]
       # @api public
       def chunked?
-        @headers[Headers::TRANSFER_ENCODING] == Headers::CHUNKED
+        @headers[Headers::TRANSFER_ENCODING].eql?(Headers::CHUNKED)
       end
 
       private
diff --git a/lib/http/response/body.rb b/lib/http/response/body.rb
@@ -110,7 +110,7 @@ def to_s
       # @return [true]
       # @api public
       def stream!
-        raise StateError, "body has already been consumed" if @streaming == false
+        raise StateError, "body has already been consumed" if @streaming.eql?(false)
 
         @streaming = true
       end
diff --git a/lib/http/uri.rb b/lib/http/uri.rb
@@ -148,7 +148,7 @@ def initialize(scheme: nil, user: nil, password: nil, host: nil,
     # @api public
     # @return [TrueClass, FalseClass] are the URIs equivalent (after normalization)?
     def ==(other)
-      other.is_a?(URI) && String(normalize) == String(other.normalize)
+      other.is_a?(URI) && String(normalize).eql?(String(other.normalize))
     end
 
     # Are these URI objects equal without normalization
@@ -162,7 +162,7 @@ def ==(other)
     # @api public
     # @return [TrueClass, FalseClass] are the URIs equivalent?
     def eql?(other)
-      other.is_a?(URI) && String(self) == String(other)
+      other.is_a?(URI) && String(self).eql?(String(other))
     end
 
     # Hash value based off the normalized form of a URI
@@ -221,7 +221,7 @@ def default_port
     # @api public
     # @return [String] origin of the URI
     def origin
-      port_suffix = ":#{port}" unless port == default_port
+      port_suffix = ":#{port}" unless port.eql?(default_port)
       "#{String(@scheme).downcase}://#{String(@raw_host).downcase}#{port_suffix}"
     end
 
@@ -282,7 +282,7 @@ def normalize
         user:     @user,
         password: @password,
         host:     @raw_host&.downcase,
-        port:     (@port unless port == default_port),
+        port:     (@port unless port.eql?(default_port)),
         path:     @path.empty? && @raw_host ? "/" : @path,
         query:    @query,
         fragment: @fragment
@@ -298,7 +298,7 @@ def normalize
     # @return [True] if URI is HTTP
     # @return [False] otherwise
     def http?
-      HTTP_SCHEME == @scheme
+      HTTP_SCHEME.eql?(@scheme)
     end
 
     # Checks whether the URI scheme is HTTPS
@@ -310,7 +310,7 @@ def http?
     # @return [True] if URI is HTTPS
     # @return [False] otherwise
     def https?
-      HTTPS_SCHEME == @scheme
+      HTTPS_SCHEME.eql?(@scheme)
     end
 
     # Duplicates the URI object
diff --git a/lib/http/uri/parsing.rb b/lib/http/uri/parsing.rb
@@ -156,7 +156,7 @@ def normalize_host(host)
       # stdlib always returns a port (defaulting to scheme's default);
       # only store it when explicitly specified
       port = parsed.port
-      port = nil if port == parsed.default_port
+      port = nil if port.eql?(parsed.default_port)
       { scheme: parsed.scheme, user: parsed.user, password: parsed.password,
         host: parsed.host, port: port, path: parsed.path,
         query: parsed.query, fragment: parsed.fragment }
diff --git a/test/http/features/caching_test.rb b/test/http/features/caching_test.rb
@@ -353,7 +353,7 @@ def make_streaming_response(status: 200, headers: {}, content: "hello", req: req
         assert_same new_response, result
       end
 
-      it "compares status code as integer, not status object" do
+      it "uses status predicate to detect 304 Not Modified" do
         entry = HTTP::Features::Caching::Entry.new(
           status:        200,
           version:       "1.1",
diff --git a/test/http/redirector_test.rb b/test/http/redirector_test.rb
@@ -530,6 +530,21 @@ def empty_body
       end
     end
 
+    it "detects endless loop when repeated URL is not the first one visited" do
+      req = HTTP::Request.new verb: :get, uri: "http://a.example.com"
+      hops = [
+        redirect_response(301, "http://b.example.com"),
+        redirect_response(301, "http://c.example.com"),
+        redirect_response(301, "http://b.example.com"),
+        redirect_response(301, "http://d.example.com"),
+        simple_response(200, "unreachable")
+      ]
+
+      assert_raises(HTTP::Redirector::EndlessRedirectError) do
+        redirector.perform(req, hops.shift) { hops.shift }
+      end
+    end
+
     context "with sensitive headers" do
       it "preserves Authorization and Cookie when redirecting to same origin" do
         req = HTTP::Request.new verb: :get, uri: "http://example.com"
diff --git a/test/http/request/body_test.rb b/test/http/request/body_test.rb
@@ -252,6 +252,20 @@
       it "returns true" do
         assert_equal body1, body2
       end
+
+      it "compares by value not identity" do
+        a = HTTP::Request::Body.new(String.new("same"))
+        b = HTTP::Request::Body.new(String.new("same"))
+
+        assert_equal a, b
+      end
+
+      it "uses == coercion on sources" do
+        a = HTTP::Request::Body.new([1])
+        b = HTTP::Request::Body.new([1.0])
+
+        assert_equal a, b
+      end
     end
 
     context "when sources are not equivalent" do
diff --git a/test/http/request/writer_test.rb b/test/http/request/writer_test.rb
@@ -126,6 +126,10 @@
         refute_includes io.string, "0\r\n\r\n"
         assert_includes io.string, "content"
       end
+
+      it "returns false from chunked?" do
+        refute_predicate writer, :chunked?
+      end
     end
 
     context "when server won't accept any more data" do
diff --git a/test/http/retriable/performer_test.rb b/test/http/retriable/performer_test.rb
@@ -167,6 +167,7 @@ def response(**options)
       describe "status codes can be expressed in many ways" do
         [
           301,
+          301.0,
           [200, 301, 485],
           250...400,
           [250...Float::INFINITY],
