Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/techdocs-cli-embedded-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@
"@backstage/catalog-model": "workspace:^",
"@backstage/cli": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs-react": "0.1.0",
Comment on lines +14 to +20
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes represent a significant downgrade and will likely break the application. The versions are being pinned to very old releases (e.g., 0.1.0 for @backstage/core-app-api when newer 1.x versions exist in the repository), and the workspace:^ protocol is being removed, which is essential for monorepo development.

This approach to fixing vulnerabilities is incorrect and harmful. Instead of downgrading, consider using Yarn's resolutions field in the root package.json to force newer, non-vulnerable versions of the transitive dependencies. For example:

"resolutions": {
  "lodash": "^4.17.21",
  "tar": "^6.1.11"
}

These changes should be reverted, and a proper dependency resolution strategy should be applied manually.

Suggested change
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs-react": "0.1.0",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs-react": "workspace:^",

"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading