Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/newrelic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +36 to +38
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @backstage/core-components and @backstage/theme to these very old versions is likely to break the application. This project uses Yarn workspaces, and the workspace:^ protocol ensures that the plugin uses the version of the package from within the monorepo.

The current versions in the workspace are:

  • @backstage/core-components: 0.13.4-next.0
  • @backstage/theme: 0.4.1

This change downgrades them to 0.1.0 and 0.1.1 respectively. This is a major regression and will likely cause compatibility issues with other packages.

While this change might resolve the reported vulnerabilities, it does so by introducing what Snyk itself flags as a breaking change. A better approach would be to address the vulnerabilities in the transitive dependencies directly, for example by using Yarn's resolutions field in the root package.json to force newer, non-vulnerable versions of the problematic packages. It's recommended to revert this change and explore alternative solutions.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading