Skip to content

[Snyk] Fix for 6 vulnerabilities #10518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 6 vulnerabilities #10518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions plugins/permission-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,18 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "1.6.1",
Comment on lines +40 to +41
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

These packages are being pinned to specific versions, replacing the workspace:^ specifier. This deviates from the monorepo setup where packages are expected to resolve to their local workspace version, which can lead to inconsistencies. The recommended approach is to keep workspace:^ and update the packages within the workspace if needed.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This package is being pinned to a specific version, replacing the workspace:^ specifier. This deviates from the monorepo setup. It's better to keep workspace:^ and update the package within the workspace if needed to resolve vulnerabilities.

Suggested change
"@backstage/plugin-auth-node": "0.6.0",
"@backstage/plugin-auth-node": "workspace:^",

"@backstage/plugin-permission-common": "0.1.0",
"@backstage/plugin-permission-node": "0.1.0",
Comment on lines +45 to +46
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These packages are being downgraded to very old versions (0.1.0). The current versions in the workspace are much newer (0.7.7 for @backstage/plugin-permission-common and 0.7.11-next.0 for @backstage/plugin-permission-node). This is a critical error, likely from the Snyk bot, that will break the application. These changes must be reverted.

Suggested change
"@backstage/plugin-permission-common": "0.1.0",
"@backstage/plugin-permission-node": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",

"@types/express": "*",
"dataloader": "^2.0.0",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"node-fetch": "^2.6.7",
"winston": "^3.2.1",
"yn": "^4.0.0",
Expand Down
Loading