Skip to content

[Snyk] Fix for 6 vulnerabilities#10520

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-69ec20a09d59e93366553e94e5d6fc0a
Closed

[Snyk] Fix for 6 vulnerabilities#10520
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-69ec20a09d59e93366553e94e5d6fc0a

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Jan 23, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/entity-validation/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

This PR pins internal Backstage dependencies to specific versions and updates lodash in the entity-validation plugin.

  • Changed @backstage/core-components from workspace:^ to 0.1.0
  • Changed @backstage/plugin-catalog-react from workspace:^ to 0.0.1
  • Changed @backstage/theme from workspace:^ to 0.1.1
  • Updated lodash from ^4.17.21 to ^4.17.23

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jan 23, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the security posture of the application by upgrading several vulnerable yarn dependencies. It addresses a range of security issues, from prototype pollution to regular expression denial of service, ensuring the project utilizes more robust and secure versions of its core libraries. The changes are primarily focused on dependency version bumps within the plugins/entity-validation module.

Highlights

  • Automated Vulnerability Fix: This pull request, automatically generated by Snyk, addresses 6 identified security vulnerabilities within the project's yarn dependencies.
  • Dependency Updates: Key dependencies including @backstage/core-components, @backstage/plugin-catalog-react, @backstage/theme, and lodash have been updated to more secure versions.
  • Critical Vulnerabilities Addressed: The fixes target a range of security issues such as Improper Handling of Unicode Encoding, Use of a Cryptographic Primitive with a Risky Implementation, UNIX Symbolic Link Following, Prototype Pollution, and Regular Expression Denial of Service (ReDoS).
  • Manual yarn.lock Update Required: A warning indicates that the yarn.lock file was not automatically updated and requires manual intervention before merging to ensure consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Jan 23, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates dependency management in the entity-validation plugin by transitioning from workspace protocol references to pinned versions for internal Backstage dependencies. The changes affect three core Backstage packages (@backstage/core-components, @backstage/plugin-catalog-react, and @backstage/theme), which are now locked to specific versions (0.1.0, 0.0.1, and 0.1.1 respectively). Additionally, the lodash dependency receives a patch version update from 4.17.21 to 4.17.23, which typically addresses security vulnerabilities or bug fixes.

Changes

File(s) Summary
plugins/entity-validation/package.json Updated three Backstage internal dependencies from workspace protocol (workspace:^) to pinned versions: @backstage/core-components to 0.1.0, @backstage/plugin-catalog-react to 0.0.1, and @backstage/theme to 0.1.1. Updated lodash from ^4.17.21 to ^4.17.23.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Registry as NPM Registry
    
    Note over Dev,Registry: Dependency Version Update Process
    
    Dev->>PM: Update package.json dependencies
    Note right of Dev: @backstage/core-components: workspace:^ → 0.1.0<br/>@backstage/plugin-catalog-react: workspace:^ → 0.0.1<br/>@backstage/theme: workspace:^ → 0.1.1<br/>lodash: ^4.17.21 → ^4.17.23
    
    Dev->>PM: Run install command
    PM->>Registry: Fetch specified versions
    Registry-->>PM: Return package artifacts
    PM->>PM: Update lock file
    PM-->>Dev: Dependencies updated
    
    Note over Dev,Registry: No runtime behavior changes<br/>Only dependency resolution modified
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix 6 vulnerabilities by updating dependencies. While the update to lodash is appropriate, the changes to several @backstage packages are highly problematic. The PR downgrades @backstage/core-components, @backstage/plugin-catalog-react, and @backstage/theme to very old versions and pins them, replacing the workspace:^ specifier. This is likely to cause significant build failures and runtime errors in this monorepo environment. I've left a critical comment with a suggestion to revert these specific changes. It's recommended to address the underlying vulnerabilities by either updating the workspace dependencies or using Yarn's resolutions feature, rather than accepting these downgrades.

Comment on lines +32 to +37
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes from workspace:^ to very old pinned versions are highly likely to break the build and cause runtime issues. In a monorepo using Yarn workspaces, workspace:^ ensures that local packages use the current versions from within the workspace. Pinning to old versions like 0.1.0 for @backstage/core-components (current is ~0.13.4), 0.0.1 for @backstage/plugin-catalog-react (current is ~1.8.1), and 0.1.1 for @backstage/theme (current is ~0.4.1) will introduce major API incompatibilities.

While this was likely done to resolve a transient dependency vulnerability, this is not the correct approach. The correct fix would be to update the dependencies in the workspace to non-vulnerable versions, or use Yarn's resolutions field in the root package.json to force a specific version of the vulnerable transitive dependency, without downgrading these direct dependencies.

It's recommended to revert these changes and investigate the vulnerabilities separately.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-common": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Apr 8, 2026
@github-actions github-actions Bot closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants