Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/entity-validation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
"dependencies": {
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +32 to +37
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes from workspace:^ to very old pinned versions are highly likely to break the build and cause runtime issues. In a monorepo using Yarn workspaces, workspace:^ ensures that local packages use the current versions from within the workspace. Pinning to old versions like 0.1.0 for @backstage/core-components (current is ~0.13.4), 0.0.1 for @backstage/plugin-catalog-react (current is ~1.8.1), and 0.1.1 for @backstage/theme (current is ~0.4.1) will introduce major API incompatibilities.

While this was likely done to resolve a transient dependency vulnerability, this is not the correct approach. The correct fix would be to update the dependencies in the workspace to non-vulnerable versions, or use Yarn's resolutions field in the root package.json to force a specific version of the vulnerable transitive dependency, without downgrading these direct dependencies.

It's recommended to revert these changes and investigate the vulnerabilities separately.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-common": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@codemirror/language": "^6.0.0",
"@codemirror/legacy-modes": "^6.1.0",
"@codemirror/view": "^6.0.0",
Expand All @@ -43,7 +43,7 @@
"@material-ui/lab": "4.0.0-alpha.61",
"@react-hookz/web": "^20.0.0",
"@uiw/react-codemirror": "^4.9.3",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"react-use": "^17.2.4",
"yaml": "^2.0.0"
},
Expand Down
Loading