Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/integration-aws-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"@aws-sdk/credential-providers": "^3.350.0",
"@aws-sdk/types": "^3.347.0",
"@aws-sdk/util-arn-parser": "^3.310.0",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^"
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1"
Comment on lines +40 to +41
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @backstage/config and @backstage/errors to version 0.1.1. The previous workspace:^ setting correctly points to the versions within this monorepo, which are 1.0.8 and 1.2.1 respectively. Downgrading these packages is a significant regression and will likely cause build failures or runtime issues.

The automated Snyk fix seems to have misinterpreted the workspace: protocol. These dependencies should remain on workspace:^ to ensure the local monorepo packages are used. The security vulnerabilities should be addressed by updating the specific transitive dependencies, potentially using resolutions in the root package.json, rather than downgrading these core packages.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1"
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^",
Expand Down
Loading