Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions plugins/catalog-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,24 +45,24 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-openapi-utils": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"@backstage/plugin-events-node": "0.4.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/plugin-search-backend-module-catalog": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-scaffolder-common": "0.1.0",
"@backstage/plugin-search-backend-module-catalog": "0.3.0",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +48 to +65
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to fixed versions are problematic in this monorepo setup. It breaks the link to the local packages and instead fetches them from the registry. This can lead to version mismatches and build failures.

For example:

  • @backstage/integration is being downgraded from a workspace version (likely based on 1.5.1 from the monorepo) to 0.1.0.
  • @backstage/backend-plugin-api is being upgraded from a workspace version (likely based on 0.5.5-next.0) to 1.6.1.

These are major version changes that will likely introduce breaking changes or cause the application to fail. While this PR is intended to fix security vulnerabilities, these changes are not safe to merge as-is. The dependencies should be updated in a way that respects the yarn workspace structure, for example by updating the versions of the packages within the monorepo itself and then running yarn to update the lockfile.

"@backstage/types": "workspace:^",
"@opentelemetry/api": "^1.3.0",
"@types/express": "^4.17.6",
Expand All @@ -75,7 +75,7 @@
"git-url-parse": "^13.0.0",
"glob": "^7.1.6",
"knex": "^2.0.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The lodash package is being updated to version ^4.17.23, but this version does not seem to exist on the public npm registry. The latest version is 4.17.21. This will likely cause the dependency installation to fail. Please verify the correct version to fix the vulnerability.

"luxon": "^3.0.0",
"minimatch": "^5.0.0",
"node-fetch": "^2.6.7",
Expand Down
Loading