Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/linguist/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-linguist-common": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/plugin-linguist-common": "0.1.0",
Comment on lines +32 to +36
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace:^ dependencies with fixed, and in some cases, very old versions. This breaks the monorepo structure and will likely cause build failures or runtime errors.

For example:

  • @backstage/core-components is being pinned to 0.1.0, but the version in this repository is 0.13.4-next.0. This is a significant downgrade.
  • @backstage/plugin-catalog-react is pinned to 0.0.1, which is also likely a very old version.

While the intention is to fix security vulnerabilities in transitive dependencies, this is not the correct approach. The workspace:^ protocol should be preserved to ensure packages within the monorepo are correctly linked.

To fix the underlying vulnerabilities, consider using Yarn's resolutions feature in the root package.json to force upgrade the vulnerable transitive dependencies across the entire workspace.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-linguist-common": "workspace:^"

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.9.13",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading