Skip to content

[Snyk] Fix for 6 vulnerabilities#10580

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-d784cd315cc2cb240c155ef8355e0d4e
Closed

[Snyk] Fix for 6 vulnerabilities#10580
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-d784cd315cc2cb240c155ef8355e0d4e

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Jan 23, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/events-backend-module-github/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

This PR converts workspace protocol dependency references to explicit version numbers in the events-backend-module-github plugin package configuration.

  • Changed @backstage/backend-plugin-api from workspace protocol to version 1.6.1
  • Changed @backstage/config from workspace protocol to version 0.1.1
  • Changed @backstage/plugin-events-node from workspace protocol to version 0.4.0
  • Pins dependencies to specific versions for independent publishing or fixed compatibility requirements

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jan 23, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Jan 23, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This automated Snyk pull request aims to enhance the project's security posture by resolving six identified vulnerabilities within its yarn dependencies. It achieves this by updating key @backstage packages in the plugins/events-backend-module-github/package.json file. Developers should be aware that a manual update of the yarn.lock file is necessary to complete the fix.

Highlights

  • Vulnerability Fixes: Addresses 6 security vulnerabilities identified by Snyk in the project's yarn dependencies, including issues related to Unicode encoding, cryptographic primitive implementation, symlink following, prototype pollution, and Regular Expression Denial of Service (ReDoS).
  • Dependency Updates: Updates @backstage/backend-plugin-api to 1.6.1, @backstage/config to 0.1.1, and @backstage/plugin-events-node to 0.4.0 in plugins/events-backend-module-github/package.json.
  • Manual yarn.lock Update Required: Notes that the yarn.lock file was not automatically updated and requires manual intervention to ensure all dependency resolutions are consistent.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm atob under CC-BY-3.0

License: CC-BY-3.0 - the applicable license policy does not allow this license (4) (package/LICENSE.DOCS)

From: ?npm/atob@2.1.2

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/atob@2.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This pull request updates the dependency management strategy for the events-backend-module-github plugin by replacing workspace protocol references with explicit version numbers. The change affects three core Backstage dependencies: backend-plugin-api (1.6.1), config (0.1.1), and plugin-events-node (0.4.0). This modification pins the package to specific dependency versions rather than relying on the monorepo workspace protocol, which typically indicates preparation for independent package publication or the establishment of fixed version compatibility requirements for more predictable dependency resolution.

Changes

File(s) Summary
plugins/events-backend-module-github/package.json Updated three Backstage dependencies from workspace protocol references to explicit version numbers: @backstage/backend-plugin-api to 1.6.1, @backstage/config to 0.1.1, and @backstage/plugin-events-node to 0.4.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PKG as package.json
    participant NPM as NPM Registry
    
    Note over Dev,NPM: Dependency Version Update (No Runtime Changes)
    
    Dev->>PKG: Update dependency versions
    Note over PKG: @backstage/backend-plugin-api: workspace:^ → 1.6.1<br/>@backstage/config: workspace:^ → 0.1.1<br/>@backstage/plugin-events-node: workspace:^ → 0.4.0
    
    Dev->>NPM: npm install
    NPM-->>Dev: Fetch published versions from registry
    
    Note over Dev,NPM: No changes to component interactions<br/>or runtime behavior
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by updating dependencies. However, the approach taken is problematic and will likely break the project.

The main issue is the replacement of workspace:^ with pinned versions for internal Backstage packages. In a Yarn workspace monorepo, workspace:^ is used to link to other packages within the same repository. Replacing this with fixed versions from an external registry will decouple this package from the monorepo, leading to version inconsistencies and likely build failures. The versions being pinned also appear to be incorrect when compared to the versions of the packages within this repository.

Furthermore, as noted in the PR description, the yarn.lock file has not been updated. This is a critical omission, and the project will not build correctly without it. The Snyk metadata itself flags this as a breaking change (isBreakingChange:true), which underscores the risk of merging this as-is.

Due to these critical issues, I recommend closing this pull request. The vulnerabilities should be addressed by updating the underlying vulnerable dependencies, potentially by running yarn upgrade for the specific packages or by updating the Backstage packages within the monorepo and letting the dependency resolution handle the updates.

Comment on lines +38 to +40
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/config": "0.1.1",
"@backstage/plugin-events-node": "0.4.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:^ with pinned versions is incorrect for a package within a Yarn workspace monorepo. This change will cause this package to use published versions from the npm registry instead of the local source code from this repository. This breaks the internal linking of the monorepo and will likely lead to build failures or runtime errors due to version mismatches.

For example, @backstage/backend-plugin-api is being pinned to 1.6.1, but the version in this monorepo appears to be 0.5.5-next.0.

These dependencies should continue to use workspace:^ to ensure they correctly resolve to the other packages within this monorepo.

Suggested change
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/config": "0.1.1",
"@backstage/plugin-events-node": "0.4.0",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Apr 6, 2026
@github-actions github-actions Bot closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants