Skip to content

[Snyk] Fix for 6 vulnerabilities#10684

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-285003d79bb9d4d07b09f7851bbba4b6
Closed

[Snyk] Fix for 6 vulnerabilities#10684
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-285003d79bb9d4d07b09f7851bbba4b6

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Jan 23, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/analytics-module-ga/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

Replaces workspace protocol dependency references with explicit semantic versions in the analytics-module-ga plugin package configuration.

  • Changed @backstage/config from workspace:^ to 0.1.1
  • Changed @backstage/theme from workspace:^ to 0.1.1
  • Changed @backstage/core-components from workspace:^ to 0.1.0
  • Changed @backstage/core-plugin-api from workspace:^ to 0.1.0
  • Indicates transition from monorepo workspace management to fixed version dependencies for publishing or release preparation

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jan 23, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Jan 23, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security by resolving six identified vulnerabilities. The changes involve updating specific @backstage dependencies within the plugins/analytics-module-ga/package.json file, transitioning them from workspace references to fixed versions. This update is crucial for mitigating various security risks present in the current dependency tree.

Highlights

  • Dependency Updates: Several @backstage dependencies in plugins/analytics-module-ga/package.json have been updated from workspace:^ to specific fixed versions (e.g., @backstage/config to 0.1.1, @backstage/core-components to 0.1.0, @backstage/core-plugin-api to 0.1.0, and @backstage/theme to 0.1.1).
  • Vulnerability Fixes: This pull request addresses 6 identified security vulnerabilities, including issues related to Improper Handling of Unicode Encoding, Use of a Cryptographic Primitive with a Risky Implementation, UNIX Symbolic Link (Symlink) Following, Prototype Pollution, and Regular Expression Denial of Service (ReDoS).
  • Manual Intervention Required: The yarn.lock file was not automatically updated and requires manual intervention before merging. Additionally, users leveraging Yarn's zero-installs feature will need to run yarn to update their .yarn/cache directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR transitions the analytics-module-ga plugin from workspace protocol dependency references to explicit semantic versioning. Four Backstage packages are updated with fixed version constraints: @backstage/config and @backstage/theme are pinned to version 0.1.1, while @backstage/core-components and @backstage/core-plugin-api are pinned to version 0.1.0. This change replaces the workspace:^ protocol with concrete version numbers, indicating a shift from monorepo workspace dependency management to explicit version pinning. This modification is typically performed during package publishing or release preparation workflows to ensure consistent dependency resolution across different environments.

Changes

File(s) Summary
plugins/analytics-module-ga/package.json Updated four Backstage package dependencies from workspace:^ protocol to explicit semantic versions: @backstage/config and @backstage/theme pinned to 0.1.1, @backstage/core-components and @backstage/core-plugin-api pinned to 0.1.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant PM as Package Manager
    participant Registry as NPM Registry
    participant GA as analytics-module-ga
    participant Config as @backstage/config
    participant Core as @backstage/core-components
    participant API as @backstage/core-plugin-api
    participant Theme as @backstage/theme

    Note over PM,Theme: Dependency Resolution Process

    PM->>GA: Read package.json
    GA-->>PM: Dependencies list

    Note over PM,Registry: Before: workspace:^ (local)<br/>After: specific versions (registry)

    PM->>Registry: Request @backstage/config@0.1.1
    Registry-->>PM: Return package
    
    PM->>Registry: Request @backstage/core-components@0.1.0
    Registry-->>PM: Return package
    
    PM->>Registry: Request @backstage/core-plugin-api@0.1.0
    Registry-->>PM: Return package
    
    PM->>Registry: Request @backstage/theme@0.1.1
    Registry-->>PM: Return package

    PM->>GA: Install resolved dependencies
    Note over GA: Dependencies now point to<br/>published versions instead<br/>of workspace packages
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix several vulnerabilities by updating dependencies. However, the proposed changes are incorrect and will likely break the application. The PR replaces workspace-relative versions (workspace:^) with old, hardcoded versions for several @backstage packages. This is a significant downgrade and breaks the monorepo's dependency management. These changes should be reverted, and the vulnerabilities should be addressed by updating the dependencies within the monorepo correctly, for example by running a dependency update command at the repository root.

Comment on lines +25 to +28
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the plugin.

  1. Incorrect Version Pinning: The change replaces workspace:^ with fixed versions. In a Yarn workspace monorepo, workspace:^ ensures that the package uses the version from the local workspace, which is crucial for development and consistency. Pinning to a specific version from the registry breaks this link.

  2. Major Version Downgrade: The versions being pinned are significant downgrades. For example:

    • @backstage/config is at version 1.0.8 in the monorepo, but is being pinned to 0.1.1.
    • @backstage/core-plugin-api is at version 1.5.3, but is being pinned to 0.1.0.

This will almost certainly lead to build failures, runtime errors, and reintroduce old bugs. The correct way to fix vulnerabilities in a monorepo is typically to update the dependencies across the entire workspace, not to pin individual package dependencies to old versions. These changes should be reverted.

    "@backstage/config": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/theme": "workspace:^"

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jan 30, 2026
@github-actions github-actions Bot closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants