Skip to content

[Snyk] Fix for 6 vulnerabilities #10684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 6 vulnerabilities #10684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/analytics-module-ga/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/theme": "0.1.1",
Comment on lines +25 to +28
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the plugin.

  1. Incorrect Version Pinning: The change replaces workspace:^ with fixed versions. In a Yarn workspace monorepo, workspace:^ ensures that the package uses the version from the local workspace, which is crucial for development and consistency. Pinning to a specific version from the registry breaks this link.

  2. Major Version Downgrade: The versions being pinned are significant downgrades. For example:

    • @backstage/config is at version 1.0.8 in the monorepo, but is being pinned to 0.1.1.
    • @backstage/core-plugin-api is at version 1.5.3, but is being pinned to 0.1.0.

This will almost certainly lead to build failures, runtime errors, and reintroduce old bugs. The correct way to fix vulnerabilities in a monorepo is typically to update the dependencies across the entire workspace, not to pin individual package dependencies to old versions. These changes should be reverted.

    "@backstage/config": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading