Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/scaffolder-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@
"dependencies": {
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Comment on lines +50 to +56
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Snyk bot has incorrectly pinned several @backstage dependencies to specific, and very old, versions. This change breaks the yarn workspace setup (workspace:^) which is crucial for a monorepo project like Backstage.

Using workspace:^ ensures that this package uses the local, up-to-date versions of other packages within the monorepo. Pinning them to published versions will likely cause:

  • Build failures.
  • Inconsistent behavior due to using outdated package versions.
  • For example, @backstage/core-components is being pinned to 0.1.0, but the version in this monorepo is 0.13.4-next.0.

These changes should be reverted. To correctly update dependencies and fix vulnerabilities in a Backstage project, you should use the tooling provided for the monorepo, such as yarn backstage-cli versions:check --fix. This will update dependencies across the entire monorepo while respecting the workspace structure.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-scaffolder-common": "workspace:^",
    "@backstage/theme": "workspace:^",
    "@backstage/types": "workspace:^"

"@backstage/version-bridge": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand All @@ -72,7 +72,7 @@
"immer": "^9.0.1",
"json-schema": "^0.4.0",
"json-schema-library": "^7.3.9",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"luxon": "^3.0.0",
"qs": "^6.9.4",
"react-use": "^17.2.4",
Expand Down
Loading