Skip to content

[Snyk] Fix for 6 vulnerabilities#10687

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-62d1fb4ff1e6fec5300a6425dd80d62d
Closed

[Snyk] Fix for 6 vulnerabilities#10687
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-62d1fb4ff1e6fec5300a6425dd80d62d

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Jan 23, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/entity-feedback/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

Updated entity-feedback plugin dependencies from workspace references to fixed version numbers.

  • Changed @backstage/core-components from workspace:^ to 0.1.0
  • Changed @backstage/plugin-catalog-react from workspace:^ to 0.0.1
  • Changed @backstage/plugin-entity-feedback-common from workspace:^ to 0.1.0
  • Transition indicates move from local workspace dependencies to published package versions

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jan 23, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Jan 23, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving six identified vulnerabilities within its yarn dependencies. The changes involve precise version updates for several @backstage packages in the plugins/entity-feedback/package.json file, directly targeting the vulnerable components.

Highlights

  • Security Vulnerability Remediation: This PR addresses six security vulnerabilities detected by Snyk, including issues such as Improper Handling of Unicode Encoding, Use of a Cryptographic Primitive with a Risky Implementation, UNIX Symbolic Link Following, Prototype Pollution, and Regular Expression Denial of Service (ReDoS).
  • Dependency Version Updates: Key @backstage dependencies within plugins/entity-feedback/package.json have been updated to specific versions (@backstage/core-components to 0.1.0, @backstage/plugin-catalog-react to 0.0.1, and @backstage/plugin-entity-feedback-common to 0.1.0) to resolve the identified vulnerabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix several vulnerabilities by updating dependencies in plugins/entity-feedback/package.json. However, the proposed changes are incorrect and will likely break the project. The PR replaces workspace:^ dependencies with outdated, fixed versions, which is improper for a Yarn workspace monorepo. This effectively downgrades several core packages, leading to incompatibilities. Additionally, as noted in the PR description, the yarn.lock file has not been updated. The changes in this PR should be reverted. The vulnerabilities should be addressed by using Yarn's resolutions feature in the root package.json to update the specific vulnerable transitive dependencies without altering the direct dependency versions in this way.

Comment on lines +31 to +35
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-entity-feedback-common": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/plugin-entity-feedback-common": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes from workspace:^ to fixed versions are incorrect and will likely break the build. In a Yarn workspace setup, workspace:^ ensures that local packages from the monorepo are used. Replacing them with specific, and in this case, very old versions, breaks this linkage and introduces significant downgrades.

For example:

  • @backstage/core-components is being downgraded to 0.1.0, while the version in the workspace is 0.13.4-next.0.
  • @backstage/plugin-catalog-react is being downgraded to 0.0.1, while recent versions are around 1.8.x.
  • @backstage/plugin-entity-feedback-common is being downgraded to 0.1.0, while the version in the workspace is 0.1.1.

These changes should be reverted. To fix the vulnerabilities, you should investigate which transitive dependencies are vulnerable and use Yarn's resolutions feature in the root package.json to force a safe version for them across the workspace, without changing these direct dependencies.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-entity-feedback-common": "workspace:^"

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates the dependency management strategy for the entity-feedback plugin by transitioning from workspace protocol references to fixed version numbers. Three Backstage packages are affected: @backstage/core-components (now v0.1.0), @backstage/plugin-catalog-react (now v0.0.1), and @backstage/plugin-entity-feedback-common (now v0.1.0). The change from workspace:^ to explicit version numbers suggests preparation for package publication or a shift in dependency resolution strategy, moving away from local workspace dependencies to versioned package references.

Changes

File(s) Summary
plugins/entity-feedback/package.json Updated three Backstage package dependencies from workspace protocol (workspace:^) to fixed versions: @backstage/core-components to 0.1.0, @backstage/plugin-catalog-react to 0.0.1, and @backstage/plugin-entity-feedback-common to 0.1.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Registry as NPM Registry
    participant Plugin as entity-feedback Plugin
    
    Note over Dev,Registry: Dependency Resolution Change
    
    Dev->>PM: npm install / yarn install
    
    alt Before Change (workspace:^)
        PM->>Plugin: Resolve @backstage/core-components
        Note over PM,Plugin: Uses local workspace version
        PM->>Plugin: Resolve @backstage/plugin-catalog-react
        Note over PM,Plugin: Uses local workspace version
        PM->>Plugin: Resolve @backstage/plugin-entity-feedback-common
        Note over PM,Plugin: Uses local workspace version
    else After Change (pinned versions)
        PM->>Registry: Fetch @backstage/core-components@0.1.0
        Registry-->>PM: Return package
        PM->>Plugin: Install core-components@0.1.0
        
        PM->>Registry: Fetch @backstage/plugin-catalog-react@0.0.1
        Registry-->>PM: Return package
        PM->>Plugin: Install plugin-catalog-react@0.0.1
        
        PM->>Registry: Fetch @backstage/plugin-entity-feedback-common@0.1.0
        Registry-->>PM: Return package
        PM->>Plugin: Install plugin-entity-feedback-common@0.1.0
    end
    
    PM-->>Dev: Dependencies installed
    
    Note over Dev,Plugin: Runtime behavior unchanged<br/>Only dependency source differs
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jan 30, 2026
@github-actions github-actions Bot closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants