Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/entity-feedback/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-entity-feedback-common": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/plugin-entity-feedback-common": "0.1.0",
Comment on lines +31 to +35
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes from workspace:^ to fixed versions are incorrect and will likely break the build. In a Yarn workspace setup, workspace:^ ensures that local packages from the monorepo are used. Replacing them with specific, and in this case, very old versions, breaks this linkage and introduces significant downgrades.

For example:

  • @backstage/core-components is being downgraded to 0.1.0, while the version in the workspace is 0.13.4-next.0.
  • @backstage/plugin-catalog-react is being downgraded to 0.0.1, while recent versions are around 1.8.x.
  • @backstage/plugin-entity-feedback-common is being downgraded to 0.1.0, while the version in the workspace is 0.1.1.

These changes should be reverted. To fix the vulnerabilities, you should investigate which transitive dependencies are vulnerable and use Yarn's resolutions feature in the root package.json to force a safe version for them across the workspace, without changing these direct dependencies.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-entity-feedback-common": "workspace:^"

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.9.13",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading