forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependency changes from
workspace:^to fixed versions are incorrect and will likely break the build. In a Yarn workspace setup,workspace:^ensures that local packages from the monorepo are used. Replacing them with specific, and in this case, very old versions, breaks this linkage and introduces significant downgrades.For example:
@backstage/core-componentsis being downgraded to0.1.0, while the version in the workspace is0.13.4-next.0.@backstage/plugin-catalog-reactis being downgraded to0.0.1, while recent versions are around1.8.x.@backstage/plugin-entity-feedback-commonis being downgraded to0.1.0, while the version in the workspace is0.1.1.These changes should be reverted. To fix the vulnerabilities, you should investigate which transitive dependencies are vulnerable and use Yarn's
resolutionsfeature in the rootpackage.jsonto force a safe version for them across the workspace, without changing these direct dependencies.