Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/apache-airflow/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +25 to +26
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly pins @backstage/core-components and @backstage/core-plugin-api to a very old version (0.1.0). The current versions in the workspace are 0.13.4-next.0 and 1.5.3 respectively. This is a significant downgrade that will almost certainly break the build and the plugin's functionality due to API incompatibilities.

The use of workspace:^ is intentional in a monorepo to ensure that packages within the workspace use the latest code from each other. Replacing it with a hardcoded version breaks this.

The Snyk PR description notes that it "Failed to update the yarn.lock", which indicates that the automated process could not correctly resolve the dependencies.

It is strongly recommended to reject this automated change and address the underlying vulnerabilities manually. A common approach in a yarn workspace is to use the resolutions field in the root package.json to force non-vulnerable versions of the transitive dependencies (like tar, lodash, etc.) across all packages.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading