Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/playlist-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
Comment on lines +25 to +32
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect for a Backstage monorepo and will likely break the application.

  1. Major Version Downgrades: Several packages are being downgraded to much older major versions. For example:

    • @backstage/catalog-client is downgraded from workspace version 1.4.3 to 0.2.0.
    • @backstage/config is downgraded from 1.0.8 to 0.1.1.
    • @backstage/plugin-auth-node is downgraded from 0.2.17-next.0 to 0.1.0.
    • @backstage/plugin-permission-node is downgraded from 0.7.11-next.0 to 0.1.0.
      These downgrades will almost certainly introduce breaking API changes and cause incompatibilities with other packages in the monorepo.
  2. Inconsistent Dependencies: This package will use old, pinned versions while other packages in the monorepo use newer versions from the workspace, leading to version conflicts.

The correct way to fix this is to update the dependencies within the monorepo packages themselves. I recommend reverting these changes.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",

"@backstage/plugin-playlist-common": "workspace:^",
"@types/express": "*",
"express": "^4.17.1",
Expand Down
Loading