Skip to content

[Snyk] Fix for 6 vulnerabilities#10720

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-10d6c4784aa4af9411cc1fdd291569e8
Closed

[Snyk] Fix for 6 vulnerabilities#10720
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-10d6c4784aa4af9411cc1fdd291569e8

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Jan 24, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/backend-plugin-api/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  208  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

This PR transitions backend-plugin-api package dependencies from workspace protocol references to fixed version specifications.

  • Changed @backstage/backend-tasks from workspace:^ to 0.6.1
  • Changed @backstage/plugin-auth-node from workspace:^ to 0.6.0
  • Changed @backstage/plugin-permission-common from workspace:^ to 0.1.0
  • Indicates transition from monorepo workspace dependencies to published package versions

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jan 24, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the project's security posture by updating critical dependencies in the backend-plugin-api package. The changes involve pinning specific versions for several @backstage related packages to resolve multiple reported vulnerabilities, ensuring the application relies on more secure and stable component versions.

Highlights

  • Vulnerability Fixes: This pull request addresses and fixes 6 identified security vulnerabilities within the project's yarn dependencies, as detected by Snyk.
  • Dependency Updates: The packages/backend-plugin-api/package.json file has been updated to specify exact versions for @backstage/backend-tasks (to 0.6.1), @backstage/plugin-auth-node (to 0.6.0), and @backstage/plugin-permission-common (to 0.1.0), moving away from workspace:^ references.
  • Manual yarn.lock Update Required: For users leveraging Yarn's zero-installs feature, a manual update of the .yarn/cache/ directory by running yarn is necessary, as the yarn.lock file was not automatically updated by this PR.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Jan 24, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates the dependency management strategy for the backend-plugin-api package by transitioning from workspace protocol references to fixed version specifications. Three Backstage packages are affected: backend-tasks, plugin-auth-node, and plugin-permission-common. The change replaces the flexible workspace:^ protocol with specific version numbers (0.6.1, 0.6.0, and 0.1.0 respectively). This modification suggests a shift from monorepo workspace dependencies to published package versions, which is typically done as part of release preparation, version pinning for stability, or updating the dependency management approach for the package.

Changes

File(s) Summary
packages/backend-plugin-api/package.json Updated three Backstage package dependencies from workspace protocol (workspace:^) to fixed versions: @backstage/backend-tasks to 0.6.1, @backstage/plugin-auth-node to 0.6.0, and @backstage/plugin-permission-common to 0.1.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant NPM as Package Manager
    participant BPA as backend-plugin-api
    participant BT as @backstage/backend-tasks v0.6.1
    participant PAN as @backstage/plugin-auth-node v0.6.0
    participant PPC as @backstage/plugin-permission-common v0.1.0

    Note over Dev,PPC: Dependency Resolution Change: workspace:^ → fixed versions

    Dev->>NPM: Install dependencies for backend-plugin-api
    activate NPM
    
    NPM->>BPA: Resolve dependencies
    activate BPA
    
    BPA->>NPM: Request @backstage/backend-tasks
    NPM->>BT: Install fixed version 0.6.1
    activate BT
    BT-->>BPA: Package installed
    deactivate BT
    
    BPA->>NPM: Request @backstage/plugin-auth-node
    NPM->>PAN: Install fixed version 0.6.0
    activate PAN
    PAN-->>BPA: Package installed
    deactivate PAN
    
    BPA->>NPM: Request @backstage/plugin-permission-common
    NPM->>PPC: Install fixed version 0.1.0
    activate PPC
    PPC-->>BPA: Package installed
    deactivate PPC
    
    BPA-->>NPM: All dependencies resolved
    deactivate BPA
    NPM-->>Dev: Installation complete
    deactivate NPM
    
    Note over BPA,PPC: Changed from workspace references to explicit versions
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix 6 vulnerabilities by updating dependencies. However, the changes made are incorrect for this monorepo. It replaces workspace:^ dependency specifiers with pinned versions, which breaks the yarn workspace setup by fetching packages from the registry instead of using local workspace packages. This can lead to major inconsistencies and build failures. Additionally, one of the packages is severely downgraded. The PR also notes that it failed to update the yarn.lock file. I've added a critical comment with a suggestion to revert these changes. The vulnerabilities should be addressed by updating the underlying transitive dependencies instead.

Comment on lines +35 to +38
"@backstage/backend-tasks": "0.6.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
"@backstage/plugin-permission-common": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to pinned versions are incorrect for this monorepo and should be reverted.

Using pinned versions instead of workspace:^ will cause these packages to be fetched from the npm registry instead of using the local packages from the workspace. This breaks the intended monorepo dependency structure and can lead to inconsistencies, build failures, and unexpected behavior, especially for local development.

The PR description itself warns: Failed to update the yarn.lock, please update manually before merging. This is a strong indicator that the automated changes are incorrect and incomplete.

For example, @backstage/plugin-permission-common is being downgraded from 0.7.7 (the version in the workspace) to 0.1.0, which is a significant breaking change and will likely cause issues.

The correct way to resolve these vulnerabilities is to identify the vulnerable transitive dependencies and update them directly, rather than changing how these direct workspace dependencies are referenced. Please revert these changes and address the underlying vulnerabilities.

Suggested change
"@backstage/backend-tasks": "0.6.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
"@backstage/plugin-permission-common": "0.1.0",
"@backstage/backend-tasks": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jan 31, 2026
@github-actions github-actions Bot closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants