Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-catalog-common": "0.1.0",
Comment on lines +39 to +43
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are highly problematic and will likely break the project.

  1. Breaking Workspace Linking: By removing workspace:^, you are decoupling this package from the versions being developed within this monorepo. This defeats a primary purpose of using a monorepo with workspaces and can lead to using stale code and hard-to-debug integration issues.

  2. Major Version Downgrades: This change downgrades several packages to significantly older, incompatible versions:

    • @backstage/catalog-model: from workspace version 1.4.1 to 0.1.1
    • @backstage/errors: from workspace version 1.2.1 to 0.1.1
    • @backstage/plugin-catalog-common: from workspace version 1.0.15 to 0.1.0

    Such drastic downgrades across major versions are guaranteed to cause API incompatibilities and break the build.

It is recommended to revert these changes. To fix the underlying security vulnerabilities, consider using Yarn's resolutions field in the root package.json to force specific versions of the vulnerable transitive dependencies.

Suggested change
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",

"@backstage/types": "workspace:^"
},
"devDependencies": {
Expand Down
Loading