Skip to content

[Snyk] Fix for 6 vulnerabilities #10765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 6 vulnerabilities #10765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/kafka/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-catalog-react": "0.0.1",
Comment on lines +29 to +31
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the application. The workspace:^ protocol is used to link to other packages within this monorepo. By replacing it with very old, hardcoded versions, you are breaking this link and introducing a massive version downgrade.

For example:

  • @backstage/core-components is being downgraded from a workspace version (the current version in the repo is 0.13.4-next.0) to 0.1.0.
  • @backstage/core-plugin-api is being downgraded from a workspace version (current is 1.5.3) to 0.1.0.
  • @backstage/plugin-catalog-react is being downgraded from a workspace version (recent versions are ~1.8.0) to 0.0.1.

This will cause major compatibility issues and almost certainly fail to build. The correct approach to fix the underlying vulnerabilities is to update the transitive dependencies that are vulnerable, not to downgrade these core packages. This PR should be rejected, and the vulnerabilities should be addressed by updating the correct packages in the monorepo. Please revert these changes.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^"

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading