Skip to content

[Snyk] Fix for 4 vulnerabilities #11565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 4 vulnerabilities #11565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/cloudbuild/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +37 to +40
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces workspace:^ with pinned, older versions of @backstage/core-components and @backstage/theme. This breaks the monorepo's workspace linking, causing this package to use outdated versions from the public registry instead of the up-to-date versions from this repository.

  • @backstage/core-components is being downgraded from workspace version 0.13.4-next.0 to 0.8.6.
  • @backstage/theme is being downgraded from workspace version 0.4.1 to 0.1.1.

This significant downgrade is very likely to cause build failures or runtime errors. The automated Snyk fix does not seem to correctly handle yarn workspaces. The vulnerabilities should be addressed without breaking the workspace setup, for example by updating the root dependencies that bring in the vulnerable packages, or by using yarn's resolutions feature in the root package.json to force newer, non-vulnerable versions of the transitive dependencies.

Suggested change
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading