Skip to content

[Snyk] Fix for 3 vulnerabilities #11566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #11566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/lighthouse-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@
"url": "https://github.com/backstage/backstage/issues"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-lighthouse-common": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/plugin-lighthouse-common": "0.1.0",
Comment on lines +41 to +48
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to pinned versions are problematic in a Yarn workspace monorepo. This will break the local workspace linking and instead pull published (and potentially outdated) versions of these packages from the npm registry.

For example, this change downgrades:

  • @backstage/catalog-client from 1.4.3 to 0.2.0
  • @backstage/plugin-catalog-node from 1.4.1-next.0 to 1.0.0
  • @backstage/plugin-lighthouse-common from 0.1.2 to 0.1.0

This can lead to build failures or subtle runtime bugs due to version mismatches.

While the intent to fix vulnerabilities is correct, the approach is not suitable for this project's structure. The correct way to resolve these vulnerabilities would be to use Yarn's resolutions feature in the root package.json to force a secure version of the transitive dependency across the entire workspace.

Pinning these dependencies to public versions should be reverted.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^",
    "@backstage/plugin-lighthouse-common": "workspace:^"

"@backstage/types": "workspace:^",
"winston": "^3.2.1"
},
Expand Down
Loading