Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/newrelic-dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +26 to +27
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes introduce a significant downgrade of core Backstage dependencies and remove the workspace:^ protocol. This will almost certainly break the application and goes against the monorepo's dependency management strategy.

  • Version Downgrade: @backstage/core-components is downgraded from a version compatible with 0.13.4-next.0 to 0.8.6. Similarly, @backstage/core-plugin-api is downgraded from 1.5.3 to 0.1.0. Such large downgrades will lead to API incompatibilities and build failures.
  • Workspace Protocol: In a Yarn workspace-based monorepo, internal packages should reference each other using workspace:^. This ensures that the versions are consistent across the entire project. Removing this will lead to dependency resolution issues and potentially multiple versions of the same package being installed.

These changes should be reverted. The underlying security vulnerabilities should be addressed by updating dependencies, not by this drastic downgrade.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^"

"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading