Skip to content

[Snyk] Fix for 3 vulnerabilities #11569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #11569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/events-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "0.1.1",
"@backstage/plugin-events-node": "0.2.9",
Comment on lines +39 to +41
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces workspace:^ dependency specifiers with pinned versions. This is highly problematic in a monorepo for several reasons:

  • Breaks Monorepo Integrity: It forces this package to use specific published versions from the registry instead of the local versions from the workspace. This can lead to having multiple, incompatible versions of the same library in the final application, causing subtle bugs and increasing bundle size.
  • Maintenance Issues: This package will no longer receive updates automatically when the workspace packages (@backstage/backend-plugin-api, @backstage/config, @backstage/plugin-events-node) are updated. It will require manual version bumps, defeating a key benefit of using a monorepo.
  • Major Version Downgrade: The version for @backstage/config is being changed from a 1.x version in the workspace to 0.1.1. This is a significant downgrade that will almost certainly break the application.

While the intent is to fix security vulnerabilities, this approach is incorrect. The vulnerabilities should be addressed by updating the underlying dependencies (like tar and eslint) within the monorepo, or by updating the workspace versions of the @backstage/* packages themselves, rather than pinning them to external versions in this one package.

Suggested change
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "0.1.1",
"@backstage/plugin-events-node": "0.2.9",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading