Skip to content

[Snyk] Fix for 4 vulnerabilities#11598

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-f248ad0f863b33988826a8f513d463cc
Closed

[Snyk] Fix for 4 vulnerabilities#11598
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-f248ad0f863b33988826a8f513d463cc

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 1, 2026

snyk-top-banner

Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/home-react/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  61  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Directory Traversal


EntelligenceAI PR Summary

This PR updates dependency management in the home-react plugin by replacing workspace protocol references with fixed version numbers for Backstage packages.

  • Changed @backstage/core-components from workspace:^ to fixed version 0.8.6
  • Changed @backstage/core-plugin-api from workspace:^ to fixed version 0.1.0
  • Transitions from local workspace dependencies to published npm registry versions
  • Modified in plugins/home-react/package.json

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 1, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving four identified vulnerabilities. It achieves this by updating specific @backstage core dependencies to newer, more secure versions. The primary impact is a reduction in security risks, though it necessitates a manual step to update the yarn.lock file for complete integration and to avoid potential issues, particularly in zero-install environments.

Highlights

  • Vulnerability Fixes: This pull request addresses and fixes 4 identified security vulnerabilities in the project's yarn dependencies, as detected and reported by Snyk.
  • Dependency Updates: The @backstage/core-components package has been updated from workspace:^ to version 0.8.6, and @backstage/core-plugin-api has been updated from workspace:^ to version 0.1.0 within the plugins/home-react/package.json file.
  • Manual yarn.lock Update Required: A critical warning indicates that the yarn.lock file was not automatically updated by Snyk and requires manual intervention to ensure consistency, especially for projects utilizing Yarn's zero-installs feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 1, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix four security vulnerabilities by pinning two dependencies in plugins/home-react/package.json to older versions. However, this approach is incorrect as it breaks the monorepo's workspace linking by replacing workspace:^ with outdated, fixed versions. This will likely lead to build failures or runtime errors. I have left a critical comment suggesting to revert these changes and instead use Yarn's resolutions to fix the transitive dependency vulnerabilities directly, which is the appropriate method for a monorepo project.

Comment on lines +36 to +37
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly modifies the dependencies from using local workspace packages (workspace:^) to using fixed, old versions from the public registry. This breaks the monorepo structure and will likely cause the application to fail to build or run correctly.

The versions being pinned are very outdated compared to the versions in this monorepo:

  • @backstage/core-components: pinned to 0.8.6, but the workspace version is 0.13.4-next.0.
  • @backstage/core-plugin-api: pinned to 0.1.0, but the workspace version is 1.5.3.

This is not the correct approach to fix security vulnerabilities in transitive dependencies. The recommended way to resolve this is to use Yarn's resolutions feature in the root package.json to force newer, non-vulnerable versions of the transitive dependencies (e.g., tar, diff, eslint).

Please revert these changes and use resolutions instead.

Suggested change
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR modifies the dependency management strategy for the home-react plugin by replacing workspace protocol references with fixed version numbers for two Backstage packages. The @backstage/core-components dependency is now pinned to version 0.8.6, and @backstage/core-plugin-api is pinned to version 0.1.0. This change transitions from using local workspace dependencies (indicated by workspace:^) to consuming specific published versions from the npm registry, which may indicate a shift from monorepo development practices to standalone package distribution or a requirement for stricter version control and dependency stability.

Changes

File(s) Summary
plugins/home-react/package.json Changed dependency version strategy from workspace protocol (workspace:^) to fixed versions: @backstage/core-components pinned to 0.8.6 and @backstage/core-plugin-api pinned to 0.1.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant WS as Workspace Registry
    participant NPM as NPM Registry
    participant Plugin as home-react Plugin

    Note over Dev,Plugin: Dependency Resolution Change

    Dev->>PM: Install dependencies for home-react
    
    alt Before Change (workspace:^)
        PM->>WS: Resolve @backstage/core-components
        WS-->>PM: Return local workspace version
        PM->>WS: Resolve @backstage/core-plugin-api
        WS-->>PM: Return local workspace version
    else After Change (pinned versions)
        PM->>NPM: Fetch @backstage/core-components@0.8.6
        NPM-->>PM: Return version 0.8.6
        PM->>NPM: Fetch @backstage/core-plugin-api@0.1.0
        NPM-->>PM: Return version 0.1.0
    end
    
    PM->>Plugin: Install resolved dependencies
    Plugin-->>Dev: Dependencies installed
    
    Note over Dev,Plugin: Plugin now uses pinned versions<br/>instead of workspace references
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 8, 2026

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 8, 2026
@github-actions github-actions Bot closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants