Skip to content

[Snyk] Fix for 4 vulnerabilities #11598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 4 vulnerabilities #11598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/home-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +36 to +37
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly modifies the dependencies from using local workspace packages (workspace:^) to using fixed, old versions from the public registry. This breaks the monorepo structure and will likely cause the application to fail to build or run correctly.

The versions being pinned are very outdated compared to the versions in this monorepo:

  • @backstage/core-components: pinned to 0.8.6, but the workspace version is 0.13.4-next.0.
  • @backstage/core-plugin-api: pinned to 0.1.0, but the workspace version is 1.5.3.

This is not the correct approach to fix security vulnerabilities in transitive dependencies. The recommended way to resolve this is to use Yarn's resolutions feature in the root package.json to force newer, non-vulnerable versions of the transitive dependencies (e.g., tar, diff, eslint).

Please revert these changes and use resolutions instead.

Suggested change
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@rjsf/utils": "5.7.3"
Expand Down
Loading