Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"start": "yarn nodemon --"
},
"dependencies": {
"@backstage/cli-common": "workspace:^",
"@backstage/cli-common": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces the yarn workspace protocol workspace:^ with a pinned version 0.1.1. In a monorepo setup like this, using workspace:^ is crucial to ensure that the local package from the workspace is used. The version of @backstage/cli-common in this workspace is 0.1.12, which is newer than the pinned version 0.1.1. Pinning to an older, specific version can break the dependency consistency within the monorepo and prevent you from getting the latest updates and fixes from the local package. It is recommended to keep using workspace:^ and run yarn install to update the yarn.lock file, which should resolve the security vulnerabilities correctly by using the workspace's version.

Suggested change
"@backstage/cli-common": "0.1.1",
"@backstage/cli-common": "workspace:^",

"chalk": "^4.0.0",
"commander": "^9.1.0",
"fs-extra": "10.1.0",
Expand Down
Loading