forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/cli-common from 0.0.0-use.local to 0.1.1 #11599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly replaces the yarn workspace protocol
workspace:^with a pinned version0.1.1. In a monorepo setup like this, usingworkspace:^is crucial to ensure that the local package from the workspace is used. The version of@backstage/cli-commonin this workspace is0.1.12, which is newer than the pinned version0.1.1. Pinning to an older, specific version can break the dependency consistency within the monorepo and prevent you from getting the latest updates and fixes from the local package. It is recommended to keep usingworkspace:^and runyarn installto update theyarn.lockfile, which should resolve the security vulnerabilities correctly by using the workspace's version.