Skip to content

[Snyk] Fix for 4 vulnerabilities #11603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 4 vulnerabilities #11603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/badges/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +33 to +37
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the application.

  1. Incorrect Dependency Pinning: This change replaces workspace:^ with pinned versions for @backstage/core-components and @backstage/theme. This breaks the yarn workspace convention used throughout this monorepo, leading to inconsistent dependency resolution.
  2. Major Version Downgrade: The versions are pinned to 0.8.6 and 0.1.1 respectively. Looking at the other packages in the repository, these are significant downgrades from the versions currently in the workspace (e.g., @backstage/core-components is at 0.13.4-next.0). Such a major downgrade is a breaking change and contradicts the PR description which mentions an 'upgrade'.
  3. Incomplete Change: The PR description warns that yarn.lock was not updated. Without updating the lock file, these dependency changes are not properly resolved and the build is likely to fail or behave unexpectedly.

It is recommended to reject this automated change. The underlying vulnerabilities should be addressed by updating the root dependencies of the monorepo, while preserving the workspace: protocol for internal packages.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading