Skip to content

[Snyk] Fix for 3 vulnerabilities #11604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #11604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions plugins/kubernetes-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,21 @@
"@aws-sdk/credential-providers": "^3.350.0",
"@aws-sdk/signature-v4": "^3.347.0",
"@azure/identity": "^3.2.1",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-kubernetes-common": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/plugin-kubernetes-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
"@google-cloud/container": "^4.0.0",
"@jest-mock/express": "^2.0.1",
"@kubernetes/client-node": "0.18.1",
"@kubernetes/client-node": "0.21.0",
Comment on lines +56 to +70
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes pin dependencies that were previously using the workspace: protocol to specific versions. While this might resolve the Snyk vulnerabilities, it's not the right approach for this monorepo as it breaks the linkage between packages.

The workspace: protocol ensures that this package always uses the version of the dependency from within this monorepo. Pinning to a specific version means this package will not receive updates when the local dependencies are updated, which can lead to inconsistencies and bugs.

Additionally, @kubernetes/client-node is upgraded across a major version (0.18.1 to 0.21.0), which could introduce breaking changes.

The PR description notes that yarn.lock failed to update. The correct fix is to resolve any issues with yarn install and update the yarn.lock file. This will update the transitive dependencies (like tar and eslint) to non-vulnerable versions without breaking the workspace setup.

Please revert these changes and run yarn install to update the lockfile. If the vulnerabilities persist, they should be addressed by updating the specific transitive dependencies or handling the major upgrade of @kubernetes/client-node in a separate, dedicated PR.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration-aws-node": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^",
    "@backstage/plugin-kubernetes-common": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-permission-node": "workspace:^",
    "@google-cloud/container": "^4.0.0",
    "@jest-mock/express": "^2.0.1",
    "@kubernetes/client-node": "0.18.1"

"@types/express": "^4.17.6",
"@types/luxon": "^3.0.0",
"compression": "^1.7.4",
Expand Down
Loading