Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/integration-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/integration": "0.1.0",
Comment on lines +26 to +29
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces a significant and likely breaking downgrade of core @backstage dependencies. The versions are being pinned to very old releases (e.g., @backstage/config from workspace version 1.0.8 to 0.1.1) and removed from the yarn workspace (workspace:^). This will almost certainly break the package and the application.

While the intent is to fix security vulnerabilities, this approach is incorrect. The packages should remain on workspace:^ to stay in sync with the monorepo. The underlying vulnerabilities should be addressed by other means, such as using yarn resolutions or performing a proper upgrade of all workspace packages together.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/integration": "0.1.0",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration": "workspace:^",

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading