Skip to content

[Snyk] Fix for 3 vulnerabilities #11607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #11607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/badges-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
Comment on lines +36 to +42
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes break the monorepo's dependency management by replacing workspace:^ with pinned versions. This will cause yarn to fetch packages from the npm registry instead of using the local packages from the workspace, which is incorrect for this project.

This is problematic for several reasons:

  • Breaks Workspaces: It defeats the purpose of yarn workspaces, which is to link local packages together in a monorepo.
  • Version Inconsistency: It introduces versions of @backstage packages that are inconsistent with the rest of the monorepo.
  • Breaking Downgrade: It downgrades @backstage/catalog-model from a workspace version that is 1.4.1 to 0.1.1. This is a significant downgrade and will likely break the build and the plugin's functionality.

The PR description itself warns "Failed to update the yarn.lock", which indicates this automated change is faulty.

The correct way to fix the underlying security vulnerabilities is to update the dependencies within the monorepo. If a transitive dependency is the issue, consider using resolutions in the root package.json to force a specific version of that transitive dependency across the entire workspace.

This automated change is incorrect and should not be merged. I suggest reverting these changes.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",

"@types/express": "^4.17.6",
"badge-maker": "^3.3.0",
"cors": "^2.8.5",
Expand Down
Loading